Review TYPO3_8-7 Merged

61001[BUGFIX] Consider default recipients in preselection check

DMK E-BUSINESS GmbH CR +2 V +2 Easy +9 −4 updated 07/05/19, 16:31

Commit message

When checking if a workspace stage has a preselection the
default recipients need to be considered, too.
Consequently the default recipients field in the TCA needs
to stay visible if the option to show the notification dialog
is unchecked.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1620

  1. DMK E-BUSINESS GmbH uploaded patch set 1 06/13/19, 13:08

  2. TYPO3com voted on patch set 1 V +1 06/13/19, 13:32 Completed build in 23m 24s on Thu, 13 Jun, 03:32 PM Test Summary: 80310 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3544

  3. Andreas Kienast commented on patch set 1 CR -1 06/13/19, 14:22

    master and 9.5 are not affected? If they are, please push a patch to master branch first.

    StageRecord.php:273

    Please no loose comparisons
  4. Oliver Klee commented on patch set 1 06/13/19, 15:01

    StageRecord.php:271

    Please let's use a return type declaration here.
  5. DMK E-BUSINESS GmbH uploaded patch set 2 06/14/19, 06:51

  6. DMK E-BUSINESS GmbH commented on patch set 1 06/14/19, 06:52

    > Patch Set 1: Code-Review-1 > > (2 comments) I'm pretty sure that 9.5 and master are affected, too, but haven't checked yet. As I'm only working in a 8.7 right now and don't have a 10 or 9.5 at hand I won't commit anything in another branch at this point. Furthermore I'm in a lack of time right now. Somebody else will have to do it, sorry. I fixed the loose comparison.
  7. DMK E-BUSINESS GmbH commented on patch set 1 06/14/19, 06:52

    > Patch Set 1: > > (1 comment) I think it's bad practice to have a return type declaration in only one method in a class when all other methods don't have it. But if you insist I will add it.
  8. TYPO3com voted on patch set 2 V +1 06/14/19, 07:13 Completed build in 22m 10s on Fri, 14 Jun, 09:13 AM Test Summary: 80310 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3547

  9. Oliver Klee commented on patch set 2 06/14/19, 13:00

    > I think it's bad practice to have a return type declaration in only one method in a class when all other methods don't have it. I disagree. I think that new code in a class should be in the best condition possible, even if the existing code is not.
  10. Oliver Klee commented on patch set 2 CR -1 06/15/19, 15:24

    -1 as this needs to go into master first.
  11. DMK E-BUSINESS GmbH uploaded patch set 3 06/17/19, 06:27

  12. TYPO3com voted on patch set 3 V +1 06/17/19, 06:49 Completed build in 22m 06s on Mon, 17 Jun, 08:49 AM Test Summary: 80310 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3548

  13. DMK E-BUSINESS GmbH commented on patch set 3 06/17/19, 13:56

    > Patch Set 2: Code-Review-1 > > -1 as this needs to go into master first. I explained briefly why I'm not able to put this into master and 9.5 first at this point. So instead of having this embarrassing bug fixed in at least one branch/version (and doing it later in newer versions) you're rejecting this patch?! It's hard to understand that decision but I guess that's how you push people away from the community, contributing and TYPO3.

    Reply Unresolved

    I'm pretty sure that 9.5 and master are affected, too, but haven't checked yet. As I'm only working in a 8.7 right now and don't have a 10 or 9.5 at hand I won't commit anything untested in another branch at this point. Furthermore I'm in a lack of time right now. Somebody else will have to do it, sorry.

    StageRecord.php:271 Reply

    I think it's bad practice to have a return type declaration in only one method in a class when all other methods don't have it. But if you insist I will add it.

    StageRecord.php:273 Reply

    Done
  14. Andreas Kienast updated the commit message in patch set 4 06/17/19, 13:59

  15. Andreas Kienast commented on patch set 4 06/17/19, 13:59

    I've cherry-picked the patch forward to 9.5 and master.
  16. DMK E-BUSINESS GmbH commented on patch set 4 06/17/19, 14:13

    > Patch Set 4: > > I've cherry-picked the patch forward to 9.5 and master. Thank you very much!
  17. TYPO3com voted on patch set 4 V +1 06/17/19, 14:33 Completed build in 26m 07s on Mon, 17 Jun, 04:33 PM Test Summary: 80310 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3549

  18. Anja Leichsenring voted on patch set 4 V +1 CR +1 07/05/19, 16:30

  19. Andreas Kienast voted on patch set 4 V +2 CR +2 07/05/19, 16:30

  20. Andreas Kienast merged patch set 5 07/05/19, 16:31