Review main Merged

61041[BUGFIX] Prevent scrollbar in "Environment Overview" modal

Jonas Eberle CR +2 V +2 Easy +12 −5 updated 06/28/19, 16:09

Commit message

Wrap potentially long version strings to prevent a horizontal
scrollbar in the modal content.

Introduces CSS class "text-wrap-allowed".

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Riccardo De Contardi +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1319

  1. Jonas Eberle uploaded patch set 1 06/14/19, 19:42

  2. Jonas Eberle updated the commit message in patch set 2 06/14/19, 19:44

  3. Jonas Eberle updated the commit message in patch set 3 06/14/19, 19:48

  4. TYPO3com voted on patch set 1 V -1 06/14/19, 20:00 Completed build in 18m 21s on Fri, 14 Jun, 10:00 PM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34353

  5. TYPO3com voted on patch set 2 V -1 06/14/19, 20:08 Completed build in 18m 39s on Fri, 14 Jun, 10:08 PM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34355

  6. TYPO3com voted on patch set 3 V -1 06/14/19, 20:14 Completed build in 24m 03s on Fri, 14 Jun, 10:14 PM Test Summary: 46487 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34357

  7. Riccardo De Contardi uploaded patch set 4 06/14/19, 21:20

  8. TYPO3com voted on patch set 4 V -1 06/14/19, 21:34 Completed build in 14m 02s on Fri, 14 Jun, 11:34 PM Test Summary: 46488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34360

  9. Riccardo De Contardi commented on patch set 4 V +1 06/14/19, 21:48

    Verified on MAC, Firefox 67.0.2, Chrome 74.0.3729.169, Safari 12.1.1; kudos to Jonas Eberle
  10. Jonas Eberle uploaded patch set 5 06/14/19, 21:54

  11. Jonas Eberle commented on patch set 5 06/14/19, 21:55

    tested with IE11, Chrome, FF, MacOS Safari
  12. TYPO3com voted on patch set 5 V -1 06/14/19, 22:08 Completed build in 13m 36s on Sat, 15 Jun, 12:08 AM Test Summary: 46488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34362

  13. Jonas Eberle uploaded patch set 6 06/14/19, 22:20

  14. TYPO3com voted on patch set 6 V +1 06/14/19, 22:33 Completed build in 12m 55s on Sat, 15 Jun, 12:33 AM Test Summary: 46488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34363

  15. Riccardo De Contardi commented on patch set 6 V +1 06/15/19, 14:49

    Verified on MAC, Firefox 67.0.2, Chrome 75.0.3770.90, Safari 12.1.1
  16. Andreas Kienast voted on patch set 6 V +1 CR +1 06/16/19, 07:56

  17. Daniel Goerz voted on patch set 6 V +2 CR +2 06/28/19, 15:49

  18. Daniel Goerz merged patch set 7 06/28/19, 15:49

  19. Daniel Goerz commented on patch set 7 06/28/19, 16:09