Review main Abandoned

61042[BUGFIX] Use string as hmac context in inline controllers

filigivuji filigivuji CR 0 V 0 Normal +47 −49 updated 03/06/20, 20:10

Commit message

The order in JSON objects is not defined and the browser can stringify
them in an arbitrary order.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 68

  1. filigivuji filigivuji uploaded patch set 1 06/14/19, 20:12

  2. TYPO3com voted on patch set 1 V -1 06/14/19, 20:27 Completed build in 14m 47s on Fri, 14 Jun, 10:27 PM Test Summary: 12 of 46827 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34358

  3. filigivuji filigivuji uploaded patch set 2 06/14/19, 20:40

  4. TYPO3com voted on patch set 2 V +1 06/14/19, 20:53 Completed build in 13m 09s on Fri, 14 Jun, 10:53 PM Test Summary: 46488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34359

  5. portrino DEV commented on patch set 2 V +1 CR +1 08/29/19, 07:47

    Code looks good and fix works in all my Use-Cases
  6. Benni Mack commented on patch set 2 CR -1 08/29/19, 14:10

    Please use your proper first + last name for authoring and voting, as this will get into GIT history.
  7. Benni Mack commented on patch set 2 12/31/19, 13:11

    please update the patch as mentioned, otherwise I need to abandon the change :(
  8. Benni Mack abandoned the change 03/06/20, 20:10

    Abandoning now. no feedback.