61043[TASK] Replace SiteMatcher with SiteFinder where applicable
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 15
- typo3/sysext/backend/Classes/Configuration/TranslationConfigurationProvider.php+9 −3
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+8 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteResolving.php+25 −2
- typo3/sysext/backend/Classes/View/PageLayoutView.php+7 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/SiteResolvingTest.php+7 −10
- typo3/sysext/core/Classes/Hooks/SiteDataHandlerCacheHook.php1deleted+0 −81
- typo3/sysext/core/Classes/Routing/PageRouter.php+3 −2
- typo3/sysext/core/ext_localconf.php+0 −5
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+9 −4
- typo3/sysext/frontend/Classes/DataProcessing/LanguageMenuProcessor.php+9 −4
- typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php+9 −4
- typo3/sysext/frontend/Classes/DataProcessing/SiteProcessor.php+5 −5
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+2 −3
- typo3/sysext/frontend/Tests/Unit/DataProcessing/SiteProcessorTest.php1+4 −4
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+6 −5
Review log 57
-
Benni Mack uploaded patch set 1 06/14/19, 21:27
-
TYPO3com voted on patch set 1 V -1 06/14/19, 21:37 Completed build in 10m 13s on Fri, 14 Jun, 11:37 PM Test Summary: 1 of 46827 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34361
-
TYPO3com voted on patch set 1 V +1 06/17/19, 04:32 Completed build in 7h 14m 49s on Mon, 17 Jun, 06:32 AM Test Summary: 46488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34361
-
Andreas Kienast voted on patch set 1 V +1 CR +1 06/17/19, 13:17
-
Benjamin Franzke commented on patch set 1 V +2 CR +2 06/17/19, 13:42
-
Benjamin Franzke merged patch set 2 06/17/19, 13:42
-
Benjamin Franzke commented on patch set 2 06/17/19, 14:39
SiteProcessorTest.php:64UnresolvedNotices this one post merge: This produces a warning, because the configuration for getAccessibleMock on line 62 hasn't been updated. BUGFIX available in https://review.typo3.org/c/Packages/TYPO3.CMS/+/61074
SiteDataHandlerCacheHook.php:50