Review main Merged

61043[TASK] Replace SiteMatcher with SiteFinder where applicable

Benni Mack CR +2 V +2 Normal +103 −136 updated 06/17/19, 14:39

Commit message

SiteMatcher is a container around SiteFinder now as PseudoSite
handling was removed, so SiteFinder can be used directly.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 57

  1. Benni Mack uploaded patch set 1 06/14/19, 21:27

  2. TYPO3com voted on patch set 1 V -1 06/14/19, 21:37 Completed build in 10m 13s on Fri, 14 Jun, 11:37 PM Test Summary: 1 of 46827 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34361

  3. TYPO3com voted on patch set 1 V +1 06/17/19, 04:32 Completed build in 7h 14m 49s on Mon, 17 Jun, 06:32 AM Test Summary: 46488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34361

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 06/17/19, 13:17

  5. Benjamin Franzke commented on patch set 1 V +2 CR +2 06/17/19, 13:42

    SiteDataHandlerCacheHook.php:50

    Great to see this anti-pattern (recreating singleton objects) removed. Helps with the implementation of a caching depndency injection container, as seen in https://review.typo3.org/c/Packages/TYPO3.CMS/+/58255/57/typo3/sysext/core/Configuration/Services.yaml#25 Thank you.
  6. Benjamin Franzke merged patch set 2 06/17/19, 13:42

  7. Benjamin Franzke commented on patch set 2 06/17/19, 14:39

    SiteProcessorTest.php:64 Unresolved

    Notices this one post merge: This produces a warning, because the configuration for getAccessibleMock on line 62 hasn't been updated. BUGFIX available in https://review.typo3.org/c/Packages/TYPO3.CMS/+/61074