61046[TASK] Switch Locales to regular singleton instance
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/Core/Bootstrap.php+0 −3
- typo3/sysext/core/Classes/Localization/LanguageService.php+1 −2
- typo3/sysext/core/Classes/Localization/Locales.php3+17 −12
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-88569-LocalesinitializeInFavorOfRegularSingletonInstance.rstnew+39 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+0 −2
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 1216
-
Benni Mack uploaded patch set 1 06/17/19, 04:56
-
TYPO3com voted on patch set 1 V -1 06/17/19, 05:10 Completed build in 13m 05s on Mon, 17 Jun, 07:10 AM Test Summary: 46488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34372
-
Benni Mack commented on patch set 2 06/17/19, 06:47
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 06/17/19, 07:19 Completed build in 28m 47s on Mon, 17 Jun, 09:19 AM Test Summary: 46488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34375
-
Benjamin Franzke voted on patch set 2 CR +1 06/17/19, 08:35
-
Benjamin Franzke voted on patch set 2 V +1 06/17/19, 12:33
-
Benni Mack uploaded patch set 3 06/17/19, 12:35
-
Benjamin Franzke uploaded patch set 4 06/17/19, 12:37
-
Benjamin Franzke voted on patch set 4 V +1 CR +1 06/17/19, 12:38
-
TYPO3com voted on patch set 3 V +1 06/17/19, 12:50 Completed build in 14m 52s on Mon, 17 Jun, 02:50 PM Test Summary: 46442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34383
-
TYPO3com commented on patch set 4 06/17/19, 12:53 Completed build in 12m 02s on Mon, 17 Jun, 02:53 PM Test Summary: 46442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34384
-
Andreas Kienast voted on patch set 4 CR +1 06/17/19, 13:15
-
Andreas Kienast commented on patch set 4 06/17/19, 13:31
Locales.php:158Should we use GeneralUtility::makeInstance(self::class) because of the SingletonInterface? -
Benjamin Franzke commented on patch set 4 06/17/19, 14:00
Locales.php:158ReplyTo be backwards compatible, yes – but to be fully backwards compatible to the prior (side) effects of Locales::initialize() we would even need to reinitialize $sharedInstance->languages and $sharedInstance->localeDependencies. -
Andreas Kienast commented on patch set 4 V +2 CR +2 06/17/19, 14:02
Locales.php:158Reply UnresolvedThanks for the explanation. I think we shouldn't do that, so: rock'n'roll. -
Andreas Kienast merged patch set 5 06/17/19, 14:02