Review 9.5 Merged

61061[BUGFIX] Remove caches for page title and meta tag

Richard Haeser CR +2 V +2 Hard +379 −90 updated 06/24/19, 18:37

Commit message

By concept for frontend rendering the page title and meta tags
are not meant to be stored in page cache in order to allow
non cachable plugins to modify those.

Currently both page title and meta tags are stored
in separate cache entries, which violates the concept above
and unnecessarily tightly couples those code parts to the
TypoScriptFrontendController and internal logic of it.

This patch removes these caches.

In order to properly handle the uncached rendering state,
we make sure the meta tag registry is properly
serialized with all managers.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 57

  1. Richard Haeser commented on patch set 1 06/21/19, 13:02

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Page/PageRenderer.php * typo3/sysext/core/Classes/PageTitle/PageTitleProviderManager.php
  2. TYPO3com voted on patch set 1 V -1 06/21/19, 13:02 Completed build in 22s on Fri, 21 Jun, 03:02 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-809

  3. Richard Haeser uploaded patch set 2 06/21/19, 14:38

  4. Richard Haeser commented on patch set 2 06/21/19, 14:40

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 06/21/19, 14:55 Completed build in 16m 12s on Fri, 21 Jun, 04:55 PM Test Summary: 50437 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-812

  6. Richard Haeser voted on patch set 2 V +2 CR +2 06/24/19, 18:37

  7. Richard Haeser merged patch set 3 06/24/19, 18:37