Review 9.5 Merged

61064[BUGFIX] Use late static binding return type for Enumeration::cast

Benni Mack CR +2 V +2 Easy +4 −5 updated 06/27/19, 11:28

Commit message

The return type annotation must be `static` instead of `self` as the
method returns an instance of the inheriting class.

Do also replace some occurrences of get_calling_class()
by static::class

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 06/27/19, 11:07

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 06/27/19, 11:21 Completed build in 14m 09s on Thu, 27 Jun, 01:21 PM Test Summary: 50467 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-830

  3. Benni Mack voted on patch set 1 V +2 CR +2 06/27/19, 11:28

  4. Benni Mack merged patch set 2 06/27/19, 11:28