Review 9.5 Merged

61067[BUGFIX] Do not rely on TYPO3_MODE for FE/BE checks

Daniel Goerz CR +2 V +2 Easy +6 −4 updated 06/27/19, 12:54

Commit message

In order to run a subrequest in Frontend,
TYPO3_MODE kills most of the functionality.

Although it is clear, that TYPO3 Core is not 100% there
yet, some very obvious changes can actually be replaced
with simple TSFE checks instead of TYPO3_MODE.

This is only focused on rendering content (Fluid),
and this happens in FE after TSFE is initialized, for eID
scripts, this would break already.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Daniel Goerz commented on patch set 1 06/27/19, 12:24

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 06/27/19, 12:42 Completed build in 16m 59s on Thu, 27 Jun, 02:42 PM Test Summary: 50467 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-833

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 06/27/19, 12:54

  4. Daniel Goerz merged patch set 2 06/27/19, 12:54