Review main Merged Breaking

61073[!!!][TASK] Remove 4th parameter of enableFields

Benni Mack CR +2 V +2 Normal +53 −38 updated 06/28/19, 11:20

Commit message

Since Versioning is completely handled via
the Context API and set within PageRepository
directly since TYPO3 v9, using the fourth
parameter would result in an invalid scenario.

Instead PageRepository->where_hid_del in
a live scenario now always contains (pid!=-1)
which filters out all non-versioned records.

This is a breaking change to avoid confusion,
however in regular scenarios this does
not affect the system, as PageRepository->versionOL()
filters out these cases in live workspace
anyways.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1

Issues 1

Files 4

Review log 1114

  1. Benni Mack uploaded patch set 1 06/17/19, 13:26

  2. TYPO3com voted on patch set 1 V +1 06/17/19, 13:37 Completed build in 10m 17s on Mon, 17 Jun, 03:37 PM Test Summary: 46442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34385

  3. Benni Mack uploaded patch set 2 06/17/19, 14:31

  4. TYPO3com voted on patch set 2 V +1 06/17/19, 14:48 Completed build in 16m 31s on Mon, 17 Jun, 04:48 PM Test Summary: 46439 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34391

  5. Andreas Kienast voted on patch set 2 CR +1 06/17/19, 14:52

  6. Oliver Klee voted on patch set 2 CR +1 06/19/19, 13:37

  7. Daniel Goerz voted on patch set 2 V +1 CR +1 06/28/19, 10:45

  8. Markus Klein commented on patch set 2 06/28/19, 10:54

    result in an invalid scenario
  9. Daniel Goerz updated the commit message in patch set 3 06/28/19, 11:05

  10. Daniel Goerz voted on patch set 3 V +1 CR +1 06/28/19, 11:05

  11. Georg Ringer voted on patch set 3 V +2 CR +2 06/28/19, 11:05

  12. Georg Ringer merged patch set 4 06/28/19, 11:05

  13. Daniel Goerz commented on patch set 4 06/28/19, 11:05

    Reply

    Done
  14. TYPO3com voted on patch set 3 V +1 06/28/19, 11:20 Completed build in 14m 41s on Fri, 28 Jun, 01:20 PM Test Summary: 46517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34604