61073[!!!][TASK] Remove 4th parameter of enableFields
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Daniel Goerz +1
-
Verified V +2 Done
- Georg Ringer +2
- Daniel Goerz +1
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/master/Breaking-88574-4thParameterOfPageRepository-enableFieldsRemoved.rstnew+40 −0
- typo3/sysext/frontend/Classes/Page/PageRepository.php+5 −6
- typo3/sysext/frontend/Tests/Functional/Page/PageRepositoryTest.php+2 −32
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedMatcher.php+6 −0
Review log 1114
-
Benni Mack uploaded patch set 1 06/17/19, 13:26
-
TYPO3com voted on patch set 1 V +1 06/17/19, 13:37 Completed build in 10m 17s on Mon, 17 Jun, 03:37 PM Test Summary: 46442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34385
-
Benni Mack uploaded patch set 2 06/17/19, 14:31
-
TYPO3com voted on patch set 2 V +1 06/17/19, 14:48 Completed build in 16m 31s on Mon, 17 Jun, 04:48 PM Test Summary: 46439 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34391
-
Andreas Kienast voted on patch set 2 CR +1 06/17/19, 14:52
-
Oliver Klee voted on patch set 2 CR +1 06/19/19, 13:37
-
Daniel Goerz voted on patch set 2 V +1 CR +1 06/28/19, 10:45
-
Markus Klein commented on patch set 2 06/28/19, 10:54
result in an invalid scenario -
Daniel Goerz updated the commit message in patch set 3 06/28/19, 11:05
-
Daniel Goerz voted on patch set 3 V +1 CR +1 06/28/19, 11:05
-
Georg Ringer voted on patch set 3 V +2 CR +2 06/28/19, 11:05
-
Georg Ringer merged patch set 4 06/28/19, 11:05
-
Daniel Goerz commented on patch set 4 06/28/19, 11:05
Reply
Done -
TYPO3com voted on patch set 3 V +1 06/28/19, 11:20 Completed build in 14m 41s on Fri, 28 Jun, 01:20 PM Test Summary: 46517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34604