Review main Merged

61074[BUGFIX] Fix getSiteFinder() mocking in SiteProcessorTest

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 06/18/19, 06:47

Commit message

As it produced a warning:
1) TYPO3\CMS\Frontend\Tests\Unit\DataProcessing\SiteProcessorTest::
  nullIsProvidedIfSiteCouldNotBeRetrieved
Trying to configure method "getSiteFinder" which cannot be configured
because it does not exist, has not been specified, is final, or is static

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 45

  1. Benjamin Franzke uploaded patch set 1 06/17/19, 14:36

  2. Benni Mack commented on patch set 1 V +1 CR +1 06/17/19, 14:40

    Aaah, thanks!
  3. TYPO3com voted on patch set 1 V +1 06/17/19, 14:55 Completed build in 15m 20s on Mon, 17 Jun, 04:55 PM Test Summary: 46442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34393

  4. Benjamin Franzke commented on patch set 1 V +2 CR +2 06/18/19, 06:47

    Merging this trival test related bugfix without a second reviewer (with Benni's agreement).
  5. Benjamin Franzke merged patch set 2 06/18/19, 06:47