Review main Abandoned

61085[BUGFIX] Fix incorrect uid_foreign after workspace publish

Christian Weiske CR 0 V 0 Easy +8 −4 updated 11/09/21, 22:04

Commit message

When inline FAL references inside a "flex" column are copied inside
a workspace, the second of the two new sys_file_reference records contains
a wrong uid_foreign value, still pointing to the original element.

When publishing this to live workspace, the reference will switch back
to the original element, and not the copied element.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1521

  1. Christian Weiske uploaded patch set 1 06/18/19, 10:06

  2. Christian Weiske updated the commit message in patch set 2 06/18/19, 10:27

  3. Oliver Hader commented on patch set 2 06/18/19, 10:35

    Nice one! Since changes in DataHander here are independent from workspaces, I would expect other new side-effects in live workspace as well. Thus, having functional tests seems to be beneficial here...
  4. TYPO3com voted on patch set 1 V +1 06/18/19, 10:50 Completed build in 30m 26s on Tue, 18 Jun, 12:50 PM Test Summary: 46442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34417

  5. TYPO3com voted on patch set 2 V +1 06/18/19, 11:06 Completed build in 21m 10s on Tue, 18 Jun, 01:06 PM Test Summary: 46442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34421

  6. Tymoteusz Motylewski commented on patch set 2 06/19/19, 21:42

    Workspaces functional tests should be extended to cover this case.
  7. Benni Mack wrote 09/27/19, 08:58

    Topic set to workspaces
  8. Benni Mack voted on patch set 2 CR +1 09/27/19, 08:58

  9. Benni Mack updated the commit message in patch set 3 11/09/19, 17:33

  10. Benni Mack rebased onto patch set 4 11/09/19, 17:33

  11. Benni Mack voted on patch set 4 CR +1 11/09/19, 17:33

  12. TYPO3com voted on patch set 3 V +1 11/09/19, 17:43 Completed build in 10m 12s on Sat, 9 Nov, 05:43 PM Test Summary: 48292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38216

  13. TYPO3com voted on patch set 4 V +1 11/09/19, 17:46 Completed build in 12m 20s on Sat, 9 Nov, 05:46 PM Test Summary: 48292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38217

  14. Benni Mack updated the commit message in patch set 5 05/25/20, 18:41

  15. Benni Mack voted on patch set 5 CR +1 05/25/20, 18:41

  16. TYPO3com voted on patch set 5 V -1 05/25/20, 19:03 Completed build in 20m 14s on Mon, 25 May, 07:03 PM Test Summary: 1 of 74292 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3524

  17. Benni Mack rebased onto patch set 6 08/31/20, 12:23

  18. Oliver Klee commented on patch set 6 08/31/20, 12:31

    Is there any way we can cover this with a test?
  19. TYPO3com voted on patch set 6 V +1 08/31/20, 12:43 Completed build in 13m 43s on Mon, 31 Aug, 12:43 PM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5087

  20. Christian Kuhn commented on patch set 6 11/09/21, 22:04

    Ping. This change is interesting and according to my (limited) flex form - workspace knowledge, still valid. However, this change will need proper test coverage with functional workspace tests, and there *are* some workspace flex form related tests by now, so this is do-able. Considering the fact nobody is actively working on this since 2019, I'm going to abandon this change for now, though: A new, and welcomed approach should come with DataHandling workspace tests to nail what happens. Until then, this patch might be ok but is mostly guesswork and we can't really estimate the impact. For now, I'll abandon this approach and will reset the issue to new.
  21. Christian Kuhn abandoned the change 11/09/21, 22:04