Review main Merged

61088[FEATURE] Allow additional file processors

Tim Schreiner CR +2 V +2 Hard +288 −47 updated 09/25/19, 11:35

Commit message

Allow registration of additional file processors.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 3850

Show 1825 earlier messages
  1. Tim Schreiner uploaded patch set 1 06/18/19, 17:41

  2. TYPO3com voted on patch set 1 V -1 06/18/19, 17:41 Completed build in 11s on Tue, 18 Jun, 07:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34429

  3. Tim Schreiner uploaded patch set 2 06/19/19, 04:30

  4. TYPO3com voted on patch set 2 V -1 06/19/19, 04:31 Completed build in 18s on Wed, 19 Jun, 06:31 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34431

  5. Helmut Hummel commented on patch set 2 06/19/19, 10:23

    ProcessorRegistry.php:93

    I wouldn't go with priorities, but with dependencies like in many other places within TYPO3
  6. Helmut Hummel commented on patch set 2 06/19/19, 10:23

    Looks pretty straightforward. Great, thanks
  7. Tim Schreiner uploaded patch set 3 06/20/19, 17:19

  8. Tim Schreiner wrote 06/20/19, 17:22

    Description set to "Use DependencyOrderService instead of Priority sorting"
  9. TYPO3com voted on patch set 3 V +1 06/20/19, 17:32 Completed build in 12m 49s on Thu, 20 Jun, 07:32 PM Test Summary: 46456 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34468

  10. Tim Schreiner updated the commit message in patch set 4 06/21/19, 12:12

  11. TYPO3com voted on patch set 4 V +1 06/21/19, 12:23 Completed build in 10m 48s on Fri, 21 Jun, 02:23 PM Test Summary: 46456 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34478

  12. Tim Schreiner uploaded patch set 5 06/21/19, 12:24

  13. TYPO3com voted on patch set 5 V +1 06/21/19, 12:35 Completed build in 11m 14s on Fri, 21 Jun, 02:35 PM Test Summary: 46456 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34479

  14. Tymoteusz Motylewski commented on patch set 5 CR -1 06/24/19, 09:11

    ProcessorRegistry.php:3

    strict type declaration missing

    ProcessorRegistry.php:54

    lets use double quotes " inside single quotes to avoid quote escaping (better readability)

    FileProcessingService.php:124

    plz add doc block

    ProcessorRegistryTest.php:3

    declare strict type please.

    ProcessorRegistryTest.php:25

    please also add a test showing that only first processor capable of processing is called.
  15. Oliver Klee commented on patch set 5 06/24/19, 13:02

    ProcessorRegistryTest.php:23

    Please let's not use the class name in the comment. It already is clear from the name of the test class, and then we don't need to manually maintain the comment when the class is renamed or moved. I propose the comment "Test case."
  16. Tim Schreiner uploaded patch set 6 06/25/19, 04:24

  17. Tim Schreiner commented on patch set 6 06/25/19, 04:30

    I added most to the suggested changes, but need some input for the test.

    ProcessorRegistry.php:3 Reply

    Done

    ProcessorRegistry.php:54 Reply

    Done

    ProcessorRegistry.php:93 Reply

    Done

    FileProcessingService.php:124 Reply

    Done

    ProcessorRegistryTest.php:3 Reply

    Done

    ProcessorRegistryTest.php:23 Reply

    Done

    ProcessorRegistryTest.php:25 Reply

    I need some input on this, how this test could work. The core currently only has one image processor. To test this case, I need two different image processors that can be checked in assert-method. Should I create two test-processors or is there a better way I'm not seeing right now?
  18. TYPO3com voted on patch set 6 V +1 06/25/19, 04:43 Completed build in 13m 45s on Tue, 25 Jun, 06:42 AM Test Summary: 46486 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34525

  19. Tymoteusz Motylewski commented on patch set 6 06/26/19, 09:39

    ProcessorRegistryTest.php:25 Reply

    Can you please check if registering the same processor twice (but under different key in global configuration) will work out?
  20. Tim Schreiner uploaded patch set 7 06/27/19, 15:53

  21. Tim Schreiner commented on patch set 7 06/27/19, 15:56

    ProcessorRegistryTest.php:25 Reply Unresolved

    If have added a test like you said. But this test does not check, which of the registered processors is used. The same class is registered and we can currently only check the resulting object, there is no way to tell, if it's the processor with key "LocalImageProcessor" or "AnotherLocalImageProcessor".
  22. TYPO3com voted on patch set 7 V +1 06/27/19, 16:04 Completed build in 11m 06s on Thu, 27 Jun, 06:04 PM Test Summary: 46532 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34580

  23. Benni Mack commented on patch set 7 06/27/19, 20:01

    DefaultConfiguration.php:247

    any reason why we should keep the "className" here - will there be more options?
  24. Tim Schreiner commented on patch set 7 06/27/19, 20:13

    DefaultConfiguration.php:247 Reply Unresolved

    There are the options "before" and "after" like in Middleware or TitleTagProviders to specifiy in which order the processors are processed. Because the first matching processor will be used. Of course they aren't used for the default Processor.
  25. Tim Schreiner uploaded patch set 8 06/27/19, 20:18

  1. TYPO3com voted on patch set 8 V +1 06/27/19, 20:37 Completed build in 18m 56s on Thu, 27 Jun, 10:37 PM Test Summary: 46532 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34590

  2. Jörg Bösche voted on patch set 8 CR +1 07/12/19, 13:32

  3. Georg Ringer commented on patch set 8 07/15/19, 08:49

    I really don'T like the word "image" in there as it is about all FAL files, so also youtube,pdf, ... or am I wrong?
  4. Tymoteusz Motylewski commented on patch set 8 07/15/19, 08:51

    > Patch Set 8: > > I really don'T like the word "image" in there as it is about all FAL files, so also youtube,pdf, ... or am I wrong? where exactly the word "image" is used in a wrong/too narrow way?
  5. Frank Nägler commented on patch set 8 07/16/19, 06:53

    In general a very good patch, the registry is very nice. But we should deprecate the old getProcessor stuff and remove it with v11.
  6. Helmut Hummel commented on patch set 8 07/16/19, 11:07

    @Frank: Deprecating a protected method? Any particular reason for that or examples where this hast been done? If I remember correctly, directly removing protected methods is fine without deprecation. In this case it even only is a wrapper for getting a singleton
  7. Helmut Hummel commented on patch set 9 07/16/19, 11:10

    Published edit on patch set 8.
  8. Helmut Hummel updated the commit message in patch set 10 07/16/19, 11:11

  9. Helmut Hummel commented on patch set 10 07/16/19, 11:12

    I changed mentions of "image processors" with "file processors", as this is more correct as Georg stated already
  10. Frank Nägler commented on patch set 10 07/16/19, 11:22

    for the record, I don't block this patch. My opinion is, this patch needs to be marked as breaking or get the deprecations. I know at least to extensions which extends (yes XCLASS...) this classes and will break. EXT:jb_gd_resize and EXT:imagickimg Since there is no other way to extend/replace the classes, we could think about deprecations here and a smoother way to upgrade. but again, this is only my personal opinion.
  11. TYPO3com voted on patch set 9 V +1 07/16/19, 11:27 Completed build in 16m 53s on Tue, 16 Jul, 01:27 PM Test Summary: 47010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35085

  12. TYPO3com voted on patch set 10 V +1 07/16/19, 11:28 Completed build in 12m 57s on Tue, 16 Jul, 01:28 PM Test Summary: 47010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35086

  13. Tim Schreiner commented on patch set 10 07/18/19, 02:35

    > Patch Set 10: > > for the record, I don't block this patch. My opinion is, this patch needs to be marked as breaking or get the deprecations. > I know at least to extensions which extends (yes XCLASS...) this classes and will break. EXT:jb_gd_resize and EXT:imagickimg > Since there is no other way to extend/replace the classes, we could think about deprecations here and a smoother way to upgrade. but again, this is only my personal opinion. I would be okay with it by marking it as breaking, because this patch changes constructor arguments of the helper classes. But deprecations should be used for public api changes.
  14. Tim Schreiner commented on patch set 10 07/18/19, 03:11

    > Patch Set 10: > > > Patch Set 10: > > > > for the record, I don't block this patch. My opinion is, this patch needs to be marked as breaking or get the deprecations. > > I know at least to extensions which extends (yes XCLASS...) this classes and will break. EXT:jb_gd_resize and EXT:imagickimg > > Since there is no other way to extend/replace the classes, we could think about deprecations here and a smoother way to upgrade. but again, this is only my personal opinion. > > I would be okay with it by marking it as breaking, because this patch changes constructor arguments of the helper classes. But deprecations should be used for public api changes. I just noticed that passing non existent constructor arguments to classes in php does not even throw a notice. Therefore a marking as breaking because of missing constructor argument would be incorrect and my argument was invalid.
  15. Tymoteusz Motylewski voted on patch set 10 CR +1 07/18/19, 07:28

  16. Markus Klein commented on patch set 11 07/18/19, 08:28

    Published edit on patch set 10.
  17. Markus Klein commented on patch set 11 CR +1 07/18/19, 08:28

    Adjusted RST slightly
  18. TYPO3com voted on patch set 11 V +1 07/18/19, 08:40 Completed build in 11m 45s on Thu, 18 Jul, 10:40 AM Test Summary: 47134 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35158

  19. Georg Ringer voted on patch set 11 V +1 CR +1 08/22/19, 06:21

  20. Guido Schmechel commented on patch set 11 08/22/19, 10:02

    Feature-88602-AllowAdditionalFileProcessors.rst:1 Unresolved

    I'm missing some documentation here, which I can do with the processors at all.So maybe 1 to 2 examples help here?
  21. Anja Leichsenring uploaded patch set 12 09/23/19, 11:49

  22. Anja Leichsenring voted on patch set 12 V +1 CR +1 09/23/19, 11:50

  23. TYPO3com voted on patch set 12 V +1 09/23/19, 12:15 Completed build in 23m 17s on Mon, 23 Sep, 12:15 PM Test Summary: 47751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36667

  24. Tymoteusz Motylewski voted on patch set 12 V +2 CR +2 09/25/19, 11:35

  25. Tymoteusz Motylewski merged patch set 13 09/25/19, 11:35