Review main Merged

61090[TASK] Remove special singleton handling of makeInstanceService

Benni Mack CR +2 V +2 Easy +0 −10 updated 06/27/19, 16:53

Commit message

Calling GeneralUtility::makeInstanceService() stores
the instance as "persistent object". Since TYPO3 4.x this has been
dealt with SingletonInterface, which allows far more flexibility
in various places, as throughout the ENTIRE TYPO3 Core already.

The special handling of having GeneralUtility::makeInstanceService()
stores its own Singleton instances is removed, as the method
calls `GeneralUtility::makeInstance()` as well, which does handle
the SingletonInterface anyway.

For services in general (like Authentication Services), it is useful
to not have them as singleton. The current process within
"makeInstanceService()" now allows to properly "reset()" the
functionality anyway by re-calling "init()", which itself
calls "reset()" as well.

As there are no contracts (interfaces) for Services currently,
this should not interfere with anything existing services.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Daniel Sattler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Daniel Sattler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 06/19/19, 09:54

  2. TYPO3com voted on patch set 1 V +1 06/19/19, 10:05 Completed build in 11m 47s on Wed, 19 Jun, 12:05 PM Test Summary: 46447 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34441

  3. Benni Mack updated the commit message in patch set 2 06/19/19, 12:39

  4. TYPO3com voted on patch set 2 V +1 06/19/19, 12:50 Completed build in 11m 15s on Wed, 19 Jun, 02:50 PM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34446

  5. Daniel Goerz voted on patch set 2 V +1 CR +1 06/27/19, 14:38

  6. Daniel Sattler voted on patch set 2 V +1 CR +1 06/27/19, 16:46

  7. Benni Mack voted on patch set 2 V +2 CR +2 06/27/19, 16:53

  8. Benni Mack merged patch set 3 06/27/19, 16:53