Review main Merged

61094[BUGFIX] Decouple ColorPicker from FormEngine

Andreas Kienast CR +2 V +2 Easy +5 −5 updated 06/27/19, 13:16

Commit message

Since #87031 the color picker is tightly coupled to FormEngine, causing
issues if not used in FormEngine context, e.g. in Constant Editor.

This patch removes the introduced FormEngine handling and uses minicolors'
events to fix the original reported bug.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Joerg Kummer +1
    • Jonas Eberle +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 79

  1. Andreas Kienast uploaded patch set 1 06/19/19, 14:03

  2. TYPO3com voted on patch set 1 V -1 06/19/19, 14:16 Completed build in 12m 31s on Wed, 19 Jun, 04:16 PM Test Summary: 1 of 46799 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34449

  3. TYPO3com voted on patch set 1 V +1 06/19/19, 14:20 Completed build in 29m 15s on Wed, 19 Jun, 04:20 PM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34449

  4. Markus Klein voted on patch set 1 CR +1 06/24/19, 07:31

  5. Susi Moog voted on patch set 1 CR +1 06/24/19, 08:10

  6. Jonas Eberle voted on patch set 1 V +1 06/24/19, 10:07

  7. Joerg Kummer voted on patch set 1 V +1 06/24/19, 10:32

  8. Daniel Goerz commented on patch set 1 V +2 CR +2 06/27/19, 13:16

    Thanks, Andy
  9. Daniel Goerz merged patch set 2 06/27/19, 13:16