Review main Merged

61095[TASK] Use generators for service objects in Authentication

Benni Mack CR +2 V +2 Easy +10 −21 updated 06/26/19, 04:18

Commit message

The introduction of the Session Framework API in v8
introduced generators for fetching authentication service
objects within `AbstractUserAuthentication`.

Some places were however forgotten, which can
safely replaced with the `$this->getAuthServices()`
method.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Alexander Schnitzler +1
    • Daniel Gorges +1
  • Verified V +2 Done
    • Benni Mack +2
    • Alexander Schnitzler +1
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1419

  1. Benni Mack uploaded patch set 1 06/19/19, 14:04

  2. TYPO3com voted on patch set 1 V +1 06/19/19, 14:19 Completed build in 13m 29s on Wed, 19 Jun, 04:19 PM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34450

  3. Andreas Kienast updated the commit message in patch set 2 06/19/19, 14:22

  4. Andreas Kienast voted on patch set 2 CR +1 06/19/19, 14:22

  5. TYPO3com voted on patch set 2 V +1 06/19/19, 14:34 Completed build in 11m 32s on Wed, 19 Jun, 04:34 PM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34451

  6. Alexander Schnitzler voted on patch set 2 V +1 CR +1 06/20/19, 09:05

  7. Alexander Schnitzler commented on patch set 2 06/20/19, 09:14

    While this patch is fine and works, I am not so sure about the benefit of using a generator here as it's not that many objects that are created. I am fine with that though. Something else is actually worse. I realised that we don't have an Interface we could use as return type like: return \Traversable|FooInterface[] That way I realised that we don't really have a contract for methods like "authGroup".
  8. Benni Mack commented on patch set 2 06/21/19, 04:16

    > Patch Set 2: > > While this patch is fine and works, I am not so sure about the benefit of using a generator here as it's not that many objects that are created. I am fine with that though. Something else is actually worse. I realised that we don't have an Interface we could use as return type like: > > return \Traversable|FooInterface[] > > That way I realised that we don't really have a contract for methods like "authGroup". Yeah, main issue here is that our own Services API does not have interfaces at all. Here's my strategy (as you can imagine I didn't do this "just because it's doable"): - Centralize usages of makeInstanceService and the Service API (with this patch it's only one occurrence) - Rework authentication API to not depend on Service API (do not extend AuthService from Abstract Service) - Replace Auth API with proper API that can be used for other auth services as well, opening auth up to the world - Deprecating Services API which Core does not use anymore
  9. Markus Klein uploaded patch set 3 06/22/19, 10:49

  10. Markus Klein voted on patch set 3 V +1 CR +1 06/22/19, 10:50

  11. TYPO3com voted on patch set 3 V +1 06/22/19, 10:59 Completed build in 10m 41s on Sat, 22 Jun, 12:59 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34511

  12. Daniel Gorges voted on patch set 3 V +1 CR +1 06/25/19, 04:31

  13. Benni Mack uploaded patch set 4 06/25/19, 10:29

  14. TYPO3com voted on patch set 4 V -1 06/25/19, 10:40 Completed build in 10m 32s on Tue, 25 Jun, 12:40 PM Test Summary: 15 of 46859 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34538

  15. TYPO3com voted on patch set 4 V +1 06/25/19, 10:49 Completed build in 29m 57s on Tue, 25 Jun, 12:49 PM Test Summary: 46508 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34538

  16. Alexander Schnitzler voted on patch set 4 V +1 CR +1 06/25/19, 13:27

  17. Daniel Gorges voted on patch set 4 V +1 CR +1 06/26/19, 04:13

  18. Benni Mack voted on patch set 4 V +2 CR +2 06/26/19, 04:18

  19. Benni Mack merged patch set 5 06/26/19, 04:18