Review main Merged

61098[TASK] Move BitSet class into different namespace

Alexander Schnitzler CR +2 V +2 Easy +10 −10 updated 06/21/19, 17:13

Commit message

The BitSet class has been put into a DataStructure
namespace although the core puts classes of these
kind into a Type namespace. Therefore, the class
has been moved.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Alexander Schnitzler +2
    • Andreas Kienast +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2327

Show 2 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 06/19/19, 16:29

  2. Oliver Klee commented on patch set 1 06/19/19, 16:41

    On it.

    BitSetTest.php:23

    This comments adds no additional information and needs to be maintained manually. Let's replace this with something that can stay as it is.
  1. Oliver Klee commented on patch set 2 06/19/19, 16:42

    Published edit on patch set 1.
  2. Oliver Klee commented on patch set 2 06/19/19, 16:42

    BitSetTest.php:23 Reply

    Done
  3. Oliver Klee commented on patch set 2 CR -1 06/19/19, 16:43

    BitSet.php:20

    Oh, here as well. Can we have some other comment here that describes the class instead of duplicating its name (which needs to be updated manually)?
  4. TYPO3com voted on patch set 1 V +1 06/19/19, 16:46 Completed build in 15m 56s on Wed, 19 Jun, 06:46 PM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34455

  5. TYPO3com voted on patch set 2 V +1 06/19/19, 16:53 Completed build in 10m 43s on Wed, 19 Jun, 06:53 PM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34456

  6. Alexander Schnitzler commented on patch set 2 06/19/19, 19:21

    BitSet.php:20 Reply

    If you like, we can remove the whole class header.
  7. Oliver Klee commented on patch set 2 06/19/19, 22:02

    BitSet.php:20 Reply Unresolved

    That would be better than the current state, but I'd really prefer a few words about the purpose of the class.
  8. Alexander Schnitzler uploaded patch set 3 06/20/19, 08:05

  9. Alexander Schnitzler commented on patch set 3 06/20/19, 08:08

    Well, I changed the class header and I'd like to have your feedback on it but I would change the class comment in a separate change because now git can't detect the move any longer. Would you be ok with that? It means that I'd repush patch set 2 and create a follow up patch for the class header.
  10. TYPO3com voted on patch set 3 V +1 06/20/19, 08:17 Completed build in 11m 16s on Thu, 20 Jun, 10:17 AM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34458

  11. Alexander Schnitzler voted on patch set 3 CR -2 06/20/19, 08:39

  12. Oliver Klee commented on patch set 3 06/20/19, 08:56

    Yes, I'd be fine with that approach. I propose I comment on the class comment in the other changeset, okay?
  13. Alexander Schnitzler uploaded patch set 4 06/20/19, 11:25

  14. Alexander Schnitzler wrote 06/20/19, 11:25

    Removed Code-Review-2 by Alexander Schnitzler <typo3@alexanderschnitzler.de>
  15. Oliver Klee voted on patch set 4 CR +1 06/20/19, 11:27

  16. TYPO3com voted on patch set 4 V +1 06/20/19, 11:36 Completed build in 11m 14s on Thu, 20 Jun, 01:36 PM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34462

  17. Mathias Brodala commented on patch set 4 CR -1 06/21/19, 07:34

    This should be marked as [!!!] breaking or a class alias should be added.
  18. Benni Mack commented on patch set 4 06/21/19, 08:24

    class was added in february for v10 only, so no breaking change.
  19. Mathias Brodala commented on patch set 4 CR +1 06/21/19, 08:33

    OK then. :-) Sorry for not checking on this.
  20. Benni Mack voted on patch set 4 V +1 CR +2 06/21/19, 11:37

  21. Andreas Kienast voted on patch set 4 V +1 CR +1 06/21/19, 12:15

  22. Alexander Schnitzler wrote 06/21/19, 15:35

    Topic set to extbase
  23. Alexander Schnitzler wrote 06/21/19, 15:35

    Hashtag added: reflection
  24. Alexander Schnitzler voted on patch set 4 V +2 06/21/19, 17:13

  25. Alexander Schnitzler merged patch set 5 06/21/19, 17:13