61098[TASK] Move BitSet class into different namespace
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Andreas Kienast +1
- Mathias Brodala +1
-
Verified V +2 Done
- Alexander Schnitzler +2
- Andreas Kienast +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 2327
Show 2 earlier messages
-
Oliver Klee commented on patch set 2 06/19/19, 16:42
Published edit on patch set 1. -
Oliver Klee commented on patch set 2 06/19/19, 16:42
BitSetTest.php:23ReplyDone -
Oliver Klee commented on patch set 2 CR -1 06/19/19, 16:43
BitSet.php:20Oh, here as well. Can we have some other comment here that describes the class instead of duplicating its name (which needs to be updated manually)? -
TYPO3com voted on patch set 1 V +1 06/19/19, 16:46 Completed build in 15m 56s on Wed, 19 Jun, 06:46 PM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34455
-
TYPO3com voted on patch set 2 V +1 06/19/19, 16:53 Completed build in 10m 43s on Wed, 19 Jun, 06:53 PM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34456
-
Alexander Schnitzler commented on patch set 2 06/19/19, 19:21
BitSet.php:20ReplyIf you like, we can remove the whole class header. -
Oliver Klee commented on patch set 2 06/19/19, 22:02
BitSet.php:20Reply UnresolvedThat would be better than the current state, but I'd really prefer a few words about the purpose of the class. -
Alexander Schnitzler uploaded patch set 3 06/20/19, 08:05
-
Alexander Schnitzler commented on patch set 3 06/20/19, 08:08
Well, I changed the class header and I'd like to have your feedback on it but I would change the class comment in a separate change because now git can't detect the move any longer. Would you be ok with that? It means that I'd repush patch set 2 and create a follow up patch for the class header. -
TYPO3com voted on patch set 3 V +1 06/20/19, 08:17 Completed build in 11m 16s on Thu, 20 Jun, 10:17 AM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34458
-
Alexander Schnitzler voted on patch set 3 CR -2 06/20/19, 08:39
-
Oliver Klee commented on patch set 3 06/20/19, 08:56
Yes, I'd be fine with that approach. I propose I comment on the class comment in the other changeset, okay? -
Alexander Schnitzler uploaded patch set 4 06/20/19, 11:25
-
Alexander Schnitzler wrote 06/20/19, 11:25
Removed Code-Review-2 by Alexander Schnitzler <typo3@alexanderschnitzler.de> -
Oliver Klee voted on patch set 4 CR +1 06/20/19, 11:27
-
TYPO3com voted on patch set 4 V +1 06/20/19, 11:36 Completed build in 11m 14s on Thu, 20 Jun, 01:36 PM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34462
-
Mathias Brodala commented on patch set 4 CR -1 06/21/19, 07:34
This should be marked as [!!!] breaking or a class alias should be added. -
Benni Mack commented on patch set 4 06/21/19, 08:24
class was added in february for v10 only, so no breaking change. -
Mathias Brodala commented on patch set 4 CR +1 06/21/19, 08:33
OK then. :-) Sorry for not checking on this. -
Benni Mack voted on patch set 4 V +1 CR +2 06/21/19, 11:37
-
Andreas Kienast voted on patch set 4 V +1 CR +1 06/21/19, 12:15
-
Alexander Schnitzler wrote 06/21/19, 15:35
Topic set to extbase -
Alexander Schnitzler wrote 06/21/19, 15:35
Hashtag added: reflection -
Alexander Schnitzler voted on patch set 4 V +2 06/21/19, 17:13
-
Alexander Schnitzler merged patch set 5 06/21/19, 17:13