Review main Merged

61100[TASK] Follow-up: Change BitSet class doc block

Alexander Schnitzler CR +2 V +2 Easy +39 −1 updated 06/24/19, 11:33

Commit message

In order to have a meaningful class doc block for the
BitSet class, the former doc block has been replaced
with an explanation of how to use the BitSet class.
The explanation is similar to the one in the rst file
which has been introduced along the class.

Review

  • Code review CR +2 Done
    • Alexander Schnitzler +2
    • Oliver Klee +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Alexander Schnitzler +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Alexander Schnitzler uploaded patch set 1 06/20/19, 11:28

  2. TYPO3com voted on patch set 1 V -1 06/20/19, 11:29 Completed build in 06s on Thu, 20 Jun, 01:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34463

  3. Oliver Klee commented on patch set 1 06/20/19, 14:29

    I like the new comment a lot!
  4. Alexander Schnitzler uploaded patch set 2 06/21/19, 18:02

  5. TYPO3com voted on patch set 2 V +1 06/21/19, 18:13 Completed build in 10m 52s on Fri, 21 Jun, 08:13 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34500

  6. Alexander Schnitzler commented on patch set 2 06/21/19, 18:16

    This change is ready for review.
  7. Oliver Klee commented on patch set 2 06/21/19, 18:19

    Looks very good! Just some smaller language nitpicks.

    BitSet.php:20

    bit wise -> bitwise

    BitSet.php:21

    api -> API
  8. Oliver Klee commented on patch set 3 06/22/19, 17:10

    Published edit on patch set 2.
  9. Oliver Klee commented on patch set 3 CR +1 06/22/19, 17:10

    BitSet.php:20 Reply

    Done

    BitSet.php:21 Reply

    Done
  10. TYPO3com voted on patch set 3 V +1 06/22/19, 17:20 Completed build in 10m 27s on Sat, 22 Jun, 07:20 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34512

  11. Björn Jacob voted on patch set 3 V +1 CR +1 06/23/19, 12:17

  12. Alexander Schnitzler voted on patch set 3 V +2 CR +2 06/24/19, 11:33

  13. Alexander Schnitzler merged patch set 4 06/24/19, 11:33