Review main Merged

61101[TASK] Streamline ClassSchema property api

Alexander Schnitzler CR +2 V +2 Normal +152 −89 updated 07/05/19, 12:48

Commit message

This patch tackles three different issues with the current
ClassSchema property api.

1) Due to the history and the refactoring of the ReflectionService,
   the ClassSchema class cached data redundantly. Information like
   the type of a property has been stored multiple times in different
   cache keys. With this patch, the redundancy has been removed.

2) The information about properties had been roughly grouped by the
   ones gathered by php reflection and the ones gathered from doc
   blocks and/or annotations. This kind of grouping had also been
   exposed to the public by different methods in the Property class.

   Said grouping has been removed and the api does no longer allow
   for requesting annotation data. The purpose of the api is to tell
   the status quo of the information about a property, regardless of
   how said information had been gathered in the first place.

   Instead of exposing the annotation data itself via method
   `getAnnotationValue('lazy')`, there is a specific method for each
   relevant piece of information like `isLazy()`.

3) A lot of information about properties are boolean values which
   had been stored as separate keys in the cache. All boolean keys
   are now represented by a BitSet, which saves quite a lot of
   bytes during serialization of ClassSchema instances.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1420

  1. Alexander Schnitzler uploaded patch set 1 06/20/19, 14:33

  2. Alexander Schnitzler uploaded patch set 2 06/20/19, 14:38

  3. TYPO3com voted on patch set 1 V -1 06/20/19, 14:44 Completed build in 11m 43s on Thu, 20 Jun, 04:44 PM Test Summary: 4 of 46799 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34464

  4. TYPO3com voted on patch set 2 V +1 06/20/19, 14:49 Completed build in 11m 15s on Thu, 20 Jun, 04:49 PM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34465

  5. Alexander Schnitzler uploaded patch set 3 06/21/19, 18:19

  6. Alexander Schnitzler wrote 06/21/19, 18:20

    Topic set to extbase
  7. TYPO3com voted on patch set 3 V -1 06/21/19, 18:22 Completed build in 02m 30s on Fri, 21 Jun, 08:22 PM Test Summary: 2428 of 22243 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34501

  8. Alexander Schnitzler uploaded patch set 4 06/21/19, 18:26

  9. TYPO3com voted on patch set 4 V +1 06/21/19, 18:38 Completed build in 12m 11s on Fri, 21 Jun, 08:38 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34503

  10. Alexander Schnitzler commented on patch set 4 06/21/19, 18:40

    This change is ready for review.
  11. Benni Mack commented on patch set 4 07/01/19, 15:04

    PropertyCharacteristics.php:3

    we need the common docheader

    PropertyCharacteristics.php:11

    maybe "final" (feel free as you please)
  12. Alexander Schnitzler commented on patch set 4 07/01/19, 15:07

    PropertyCharacteristics.php:3 Reply Unresolved

    Ack

    PropertyCharacteristics.php:11 Reply Unresolved

    Ack
  13. Alexander Schnitzler uploaded patch set 5 07/01/19, 15:17

  14. TYPO3com voted on patch set 5 V +1 07/01/19, 15:28 Completed build in 10m 49s on Mon, 1 Jul, 05:28 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34694

  15. Anja Leichsenring voted on patch set 5 V +1 CR +1 07/05/19, 12:19

  16. Andreas Kienast commented on patch set 6 07/05/19, 12:37

    Published edit on patch set 5.
  17. Andreas Kienast voted on patch set 6 V +1 CR +1 07/05/19, 12:37

  18. TYPO3com voted on patch set 6 V +1 07/05/19, 12:48 Completed build in 10m 39s on Fri, 5 Jul, 02:48 PM Test Summary: 46700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34805

  19. Anja Leichsenring voted on patch set 6 V +2 CR +2 07/05/19, 12:48

  20. Anja Leichsenring merged patch set 7 07/05/19, 12:48