61101[TASK] Streamline ClassSchema property api
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Andreas Kienast +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/extbase/Classes/Object/Container/Container.php+3 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+2 −2
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Exception/NoSuchPropertyException.php+13 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Property.php+53 −21
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/PropertyCharacteristics.php4new+33 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+35 −48
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/PersistentObjectConverterTest.php+3 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/PropertyTest.php+5 −9
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+4 −4
Review log 1420
-
Alexander Schnitzler uploaded patch set 1 06/20/19, 14:33
-
Alexander Schnitzler uploaded patch set 2 06/20/19, 14:38
-
TYPO3com voted on patch set 1 V -1 06/20/19, 14:44 Completed build in 11m 43s on Thu, 20 Jun, 04:44 PM Test Summary: 4 of 46799 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34464
-
TYPO3com voted on patch set 2 V +1 06/20/19, 14:49 Completed build in 11m 15s on Thu, 20 Jun, 04:49 PM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34465
-
Alexander Schnitzler uploaded patch set 3 06/21/19, 18:19
-
Alexander Schnitzler wrote 06/21/19, 18:20
Topic set to extbase -
TYPO3com voted on patch set 3 V -1 06/21/19, 18:22 Completed build in 02m 30s on Fri, 21 Jun, 08:22 PM Test Summary: 2428 of 22243 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34501
-
Alexander Schnitzler uploaded patch set 4 06/21/19, 18:26
-
TYPO3com voted on patch set 4 V +1 06/21/19, 18:38 Completed build in 12m 11s on Fri, 21 Jun, 08:38 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34503
-
Alexander Schnitzler commented on patch set 4 06/21/19, 18:40
This change is ready for review. -
Benni Mack commented on patch set 4 07/01/19, 15:04
PropertyCharacteristics.php:3we need the common docheaderPropertyCharacteristics.php:11maybe "final" (feel free as you please) -
Alexander Schnitzler commented on patch set 4 07/01/19, 15:07
PropertyCharacteristics.php:3Reply UnresolvedAckPropertyCharacteristics.php:11Reply UnresolvedAck -
Alexander Schnitzler uploaded patch set 5 07/01/19, 15:17
-
TYPO3com voted on patch set 5 V +1 07/01/19, 15:28 Completed build in 10m 49s on Mon, 1 Jul, 05:28 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34694
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 07/05/19, 12:19
-
Andreas Kienast commented on patch set 6 07/05/19, 12:37
Published edit on patch set 5. -
Andreas Kienast voted on patch set 6 V +1 CR +1 07/05/19, 12:37
-
TYPO3com voted on patch set 6 V +1 07/05/19, 12:48 Completed build in 10m 39s on Fri, 5 Jul, 02:48 PM Test Summary: 46700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34805
-
Anja Leichsenring voted on patch set 6 V +2 CR +2 07/05/19, 12:48
-
Anja Leichsenring merged patch set 7 07/05/19, 12:48