Review main Merged

61102[BUGFIX] AbstractSubModule implements ContentProviderInterface by default

Jan Stockfisch CR +2 V +2 Easy +7 −14 updated 10/07/19, 12:17

Commit message

Because all submodules must implement the interface anyway, it's now
implemented by default in the AbstractSubModule. Without implementing
an InvalidArgumentException is thrown.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Steffen Frese +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Steffen Frese +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1320

  1. Jan Stockfisch uploaded patch set 1 06/20/19, 17:11

  2. Jan Stockfisch updated the commit message in patch set 2 06/20/19, 17:14

  3. Jan Stockfisch wrote 06/20/19, 17:15

    Topic set to adminpanel
  4. TYPO3com voted on patch set 1 V +1 06/20/19, 17:24 Completed build in 13m 01s on Thu, 20 Jun, 07:24 PM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34466

  5. TYPO3com voted on patch set 2 V +1 06/20/19, 17:28 Completed build in 13m 59s on Thu, 20 Jun, 07:28 PM Test Summary: 46448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34467

  6. Steffen Frese voted on patch set 2 V +1 CR +1 07/09/19, 07:16

  7. Jan Stockfisch rebased onto patch set 3 07/12/19, 12:38

  8. Jörg Bösche voted on patch set 3 CR +1 07/12/19, 12:57

  9. TYPO3com voted on patch set 3 V +1 07/12/19, 13:03 Completed build in 17m 01s on Fri, 12 Jul, 03:03 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34965

  10. Jan Stockfisch uploaded patch set 4 08/14/19, 15:22

  11. Jan Stockfisch commented on patch set 4 08/14/19, 15:23

    rebased and resolved merge conflicts
  12. TYPO3com voted on patch set 4 V +1 08/14/19, 15:30 Completed build in 08m 13s on Wed, 14 Aug, 03:30 PM Test Summary: 47176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35694

  13. Jan Stockfisch rebased onto patch set 5 08/26/19, 15:12

  14. TYPO3com voted on patch set 5 V +1 08/26/19, 15:24 Completed build in 11m 47s on Mon, 26 Aug, 03:24 PM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35849

  15. Jan Stockfisch rebased onto patch set 6 10/07/19, 07:12

  16. TYPO3com voted on patch set 6 V -1 10/07/19, 07:26 Completed build in 12m 01s on Mon, 7 Oct, 07:26 AM Test Summary: 1 of 48118 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37076

  17. TYPO3com voted on patch set 6 V +1 10/07/19, 08:22 Completed build in 1h 20m 11s on Mon, 7 Oct, 08:22 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37076

  18. Steffen Frese voted on patch set 6 V +1 CR +1 10/07/19, 08:27

  19. Frank Nägler voted on patch set 6 V +2 CR +2 10/07/19, 12:16

  20. Frank Nägler merged patch set 7 10/07/19, 12:17