61104[TASK] Improve ViewHelper documentation
Commit message
Review
-
Code review CR +2 Done
- Tymoteusz Motylewski +2
- Daniel Goerz +1
-
Verified V +2 Done
- Tymoteusz Motylewski +2
- Daniel Goerz +1
- TYPO3com +1 CI
Files 81
- typo3/sysext/backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php+2 −2
- typo3/sysext/backend/Classes/ViewHelpers/Link/NewRecordViewHelper.php+5 −5
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayout/Button/LinkButtonViewHelper.php+6 −6
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayout/Button/ShortcutButtonViewHelper.php+2 −2
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayout/MenuItemViewHelper.php+4 −4
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayout/MenuViewHelper.php2+7 −6
- typo3/sysext/backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php+2 −2
- typo3/sysext/backend/Classes/ViewHelpers/AvatarViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayoutViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php+16 −1
- typo3/sysext/core/Classes/ViewHelpers/IconForRecordViewHelper.php+16 −1
- typo3/sysext/core/Classes/ViewHelpers/IconForResourceViewHelper.php+16 −1
- typo3/sysext/core/Classes/ViewHelpers/IconViewHelper.php+28 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Buttons/CshViewHelper.php+10 −5
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Buttons/ShortcutViewHelper.php+6 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Labels/CshViewHelper.php+9 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemViewHelper.php+6 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuViewHelper.php+5 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Security/IfAuthenticatedViewHelper.php+6 −3
Show 61 more files
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Security/IfHasRoleViewHelper.php+12 −5
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Widget/PaginateViewHelper.php2+4 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Be/ContainerViewHelper.php+11 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageInfoViewHelper.php+4 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PagePathViewHelper.php+4 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageRendererViewHelper.php+7 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+19 −5
- typo3/sysext/fluid/Classes/ViewHelpers/Debug/RenderViewHelper.php+6 −7
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptgroupViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptionViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ButtonViewHelper.php+6 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CheckboxViewHelper.php+15 −6
- typo3/sysext/fluid/Classes/ViewHelpers/Form/HiddenViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Form/PasswordViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/RadioViewHelper.php+15 −6
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+25 −18
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SubmitViewHelper.php+8 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextareaViewHelper.php+3 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextfieldViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/UploadViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Format/BytesViewHelper.php+18 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CaseViewHelper.php+17 −7
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php+38 −15
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CurrencyViewHelper.php+36 −11
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php+36 −15
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesDecodeViewHelper.php+13 −7
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesViewHelper.php+13 −7
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php+17 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Format/JsonViewHelper.php+16 −6
- typo3/sysext/fluid/Classes/ViewHelpers/Format/Nl2brViewHelper.php+12 −6
- typo3/sysext/fluid/Classes/ViewHelpers/Format/NumberViewHelper.php+12 −5
- typo3/sysext/fluid/Classes/ViewHelpers/Format/PaddingViewHelper.php+19 −6
- typo3/sysext/fluid/Classes/ViewHelpers/Format/StripTagsViewHelper.php+28 −12
- typo3/sysext/fluid/Classes/ViewHelpers/Format/UrlencodeViewHelper.php2+17 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/EmailViewHelper.php+14 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Link/ExternalViewHelper.php+8 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Link/PageViewHelper.php+18 −9
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php+22 −7
- typo3/sysext/fluid/Classes/ViewHelpers/Security/IfAuthenticatedViewHelper.php+13 −6
- typo3/sysext/fluid/Classes/ViewHelpers/Security/IfHasRoleViewHelper.php+22 −9
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ActionViewHelper.php+3 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/EmailViewHelper.php+4 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ExternalViewHelper.php+8 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ImageViewHelper.php+30 −9
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/PageViewHelper.php+21 −9
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ResourceViewHelper.php+17 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/TypolinkViewHelper.php+19 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/AutocompleteViewHelper.php+11 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/LinkViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/PaginateViewHelper.php+8 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/UriViewHelper.php+4 −3
- typo3/sysext/fluid/Classes/ViewHelpers/BaseViewHelper.php+4 −4
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php2+35 −7
- typo3/sysext/fluid/Classes/ViewHelpers/DebugViewHelper.php+16 −3
- typo3/sysext/fluid/Classes/ViewHelpers/FlashMessagesViewHelper.php+16 −5
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+7 −7
- typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php+26 −11
- typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php+14 −5
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php4+50 −36
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+1 −1
Review log 2028
Show 23 earlier messages
-
Daniel Siepmann uploaded patch set 1 06/21/19, 07:44
-
Daniel Siepmann marked it work in progress 06/21/19, 07:44
-
TYPO3com voted on patch set 1 V -1 06/21/19, 07:44 Completed build in 11s on Fri, 21 Jun, 09:44 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34471
-
Daniel Siepmann uploaded patch set 2 06/21/19, 09:43
-
TYPO3com voted on patch set 2 V -1 06/21/19, 09:43 Completed build in 18s on Fri, 21 Jun, 11:43 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34472
-
Daniel Siepmann uploaded patch set 3 06/21/19, 13:34
-
TYPO3com voted on patch set 3 V -1 06/21/19, 13:35 Completed build in 28s on Fri, 21 Jun, 03:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34485
-
Daniel Siepmann uploaded patch set 4 06/21/19, 13:57
-
TYPO3com voted on patch set 4 V -1 06/21/19, 13:57 Completed build in 15s on Fri, 21 Jun, 03:57 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34487
-
Daniel Siepmann commented on patch set 4 06/21/19, 13:58
This change is ready for review. -
Daniel Siepmann uploaded patch set 5 06/21/19, 14:02
-
TYPO3com voted on patch set 5 V +1 06/21/19, 14:13 Completed build in 10m 30s on Fri, 21 Jun, 04:13 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34488
-
Tom Warwick voted on patch set 5 V +1 06/21/19, 14:19
-
Daniel Siepmann uploaded patch set 6 06/21/19, 14:54
-
TYPO3com voted on patch set 6 V +1 06/21/19, 15:05 Completed build in 10m 45s on Fri, 21 Jun, 05:05 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34492
-
Tymoteusz Motylewski voted on patch set 6 CR +1 06/29/19, 18:14
-
Simon Gilli commented on patch set 6 06/30/19, 12:07
Great Daniel, thank you! Found 2 minor things, have a look at my commentsUrlencodeViewHelper.php:23Shouldn't that be https too?TranslateViewHelper.php:78That's now `Neos Flow` see https://de.wikipedia.org/wiki/Flow_Framework -
Simon Gilli voted on patch set 6 CR +1 06/30/19, 12:08
-
Daniel Goerz commented on patch set 6 07/01/19, 08:21
MenuViewHelper.php:31This sentence is messed upPaginateViewHelper.php:24with required arguments onlyCObjectViewHelper.php:60This should also contain an example how to use the data in the TypoScript ObjectTranslateViewHelper.php:78ReplyI dont think this adds any value to the documentation. I would just remove this note. -
Tymoteusz Motylewski commented on patch set 6 CR 0 07/01/19, 08:31
TranslateViewHelper.php:78ReplyI would remove the sentence completely. As this code is TYPO3 CMS only. -
Daniel Goerz commented on patch set 7 07/01/19, 18:33
Published edit on patch set 6. -
TYPO3com voted on patch set 7 V -1 07/01/19, 18:33 Completed build in 13s on Mon, 1 Jul, 08:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34699
-
Daniel Goerz commented on patch set 7 07/01/19, 18:35
MenuViewHelper.php:31ReplyDonePaginateViewHelper.php:24ReplyDoneCObjectViewHelper.php:60ReplyDoneUrlencodeViewHelper.php:23Reply UnresolvedThe URL does not work with SSLTranslateViewHelper.php:78ReplyDone -
Daniel Goerz commented on patch set 8 07/01/19, 18:35
Published edit on patch set 7. -
TYPO3com voted on patch set 8 V +1 07/01/19, 18:47 Completed build in 11m 21s on Mon, 1 Jul, 08:47 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34700
-
Daniel Goerz voted on patch set 8 V +1 CR +1 07/01/19, 18:48
-
Tymoteusz Motylewski voted on patch set 8 V +2 CR +2 07/01/19, 21:30
-
Tymoteusz Motylewski merged patch set 9 07/01/19, 21:30