Review main Merged

61108[TASK] Remove backend user ID from workspace preview config

Benni Mack CR +2 V +2 Easy +2 −5 updated 06/24/19, 09:54

Commit message

The configuration within `sys_preview` contained the
Backend User ID. Previously, until TYPO3 v9, this was
used to simulate a backend user with his/her permissions,
however this was changed with the introduction of Middlewares
and a custom PreviewUserAuthentication object.

This information does not need to be stored, as it hasn't
been evaluated anymore anyways.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 06/21/19, 11:03

  2. Daniel Goerz voted on patch set 1 V +1 CR +1 06/21/19, 11:07

  3. TYPO3com voted on patch set 1 V +1 06/21/19, 11:15 Completed build in 11m 26s on Fri, 21 Jun, 01:15 PM Test Summary: 46446 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34476

  4. Alexander Schnitzler commented on patch set 1 V +1 CR +1 06/21/19, 11:40

    Verified by checking that the string 'BEUSER_uid' cannot be found in the core.
  5. Benni Mack voted on patch set 1 V +2 CR +2 06/24/19, 09:54

  6. Benni Mack merged patch set 2 06/24/19, 09:54