61116[FEATURE] Page title providers visible in admin panel
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Susi Moog +1
-
Verified V +2 Done
- Daniel Goerz +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/adminpanel/Classes/Modules/Debug/PageTitle.php2new+124 −0
- typo3/sysext/adminpanel/Resources/Private/Language/locallang_debug.xlf+27 −0
- typo3/sysext/adminpanel/Resources/Private/Templates/Modules/Debug/PageTitle.html3new+65 −0
- typo3/sysext/adminpanel/ext_localconf.php+3 −0
- typo3/sysext/core/Classes/PageTitle/PageTitleProviderManager.php1+18 −3
Review log 2030
Show 45 earlier messages
-
Riny van Tiggelen uploaded patch set 1 06/21/19, 15:24
-
Riny van Tiggelen marked it work in progress 06/21/19, 15:34
-
TYPO3com voted on patch set 1 V +1 06/21/19, 15:37 Completed build in 13m 13s on Fri, 21 Jun, 05:37 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34494
-
Richard Haeser commented on patch set 1 06/28/19, 19:02
Working correctly, maybe do the markup a little bit different. Will send you a possible solution via Slack. -
Richard Haeser commented on patch set 1 CR -1 06/28/19, 19:05
PageTitle.php:28UnresolvedThis comment is leftover after copying the example.PageTitle.html:2UnresolvedLanguage labels?
-
Riny van Tiggelen uploaded patch set 2 07/17/19, 17:27
-
Riny van Tiggelen updated the commit message in patch set 3 07/17/19, 17:29
-
Riny van Tiggelen commented on patch set 3 07/17/19, 17:29
This change is ready for review. -
TYPO3com voted on patch set 2 V +1 07/17/19, 17:40 Completed build in 12m 09s on Wed, 17 Jul, 07:40 PM Test Summary: 47118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35139
-
TYPO3com voted on patch set 3 V +1 07/17/19, 17:43 Completed build in 14m 00s on Wed, 17 Jul, 07:43 PM Test Summary: 47118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35140
-
Riny van Tiggelen commented on patch set 3 07/17/19, 17:44
https://review.typo3.org/c/Packages/TYPO3.CMS/+/61298 should be merged before this can be reviewed -
Richard Haeser commented on patch set 3 V -1 07/17/19, 17:53
It only results in info when content is not cached -
Riny van Tiggelen uploaded patch set 4 07/17/19, 19:37
-
TYPO3com voted on patch set 4 V +1 07/17/19, 19:49 Completed build in 11m 45s on Wed, 17 Jul, 09:49 PM Test Summary: 47122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35144
-
Riny van Tiggelen updated the commit message in patch set 5 07/23/19, 13:25
-
TYPO3com voted on patch set 5 V +1 07/23/19, 13:35 Completed build in 10m 07s on Tue, 23 Jul, 03:35 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35294
-
Guido Schmechel commented on patch set 5 V +1 CR +1 07/23/19, 19:09
I had to perform a rebase locally once. Before, there was an error message in the file typo3/sysext/adminpanel/Classes/Modules/PreviewModule.php (Old TSFE function?) After that, everything went smoothly. -
Jörg Bösche commented on patch set 5 CR -1 08/01/19, 08:34
PageTitleProviderManager.php:38UnresolvedYou can use our LoggerTrait https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/Logging/Logger/Index.html#instantiation instead of initialize the logger in the constructor. -
Riny van Tiggelen rebased onto patch set 6 10/10/19, 17:05
-
TYPO3com voted on patch set 6 V -1 10/10/19, 17:15 Completed build in 10m 22s on Thu, 10 Oct, 05:15 PM Test Summary: 37445 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37227
-
Riny van Tiggelen uploaded patch set 7 10/10/19, 17:22
-
TYPO3com voted on patch set 7 V -1 10/10/19, 17:34 Completed build in 11m 19s on Thu, 10 Oct, 05:34 PM Test Summary: 1 of 48341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37229
-
TYPO3com voted on patch set 7 V +1 10/10/19, 18:05 Completed build in 54m 07s on Thu, 10 Oct, 06:05 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37229
-
Jan Stockfisch commented on patch set 7 V +1 CR -1 10/11/19, 09:53
PageTitle.php:33UnresolvedContentProviderInterface is now already implemented by extending AbstractSubModule.PageTitle.html:37UnresolvedCan we switch the `td`'s so it's streamlined to the first table? IMHO it looks cleaner that way.PageTitle.html:56UnresolvedSame here -
Jan Stockfisch uploaded patch set 8 10/11/19, 15:17
-
TYPO3com voted on patch set 8 V -1 10/11/19, 15:30 Completed build in 13m 28s on Fri, 11 Oct, 03:30 PM Test Summary: 1 of 48341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37272
-
TYPO3com voted on patch set 8 V +1 10/11/19, 15:48 Completed build in 10m 27s on Fri, 11 Oct, 03:48 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37273
-
Susi Moog voted on patch set 8 V +1 CR +1 11/09/19, 16:03
-
Daniel Goerz voted on patch set 8 V +2 CR +2 11/09/19, 16:22
-
Daniel Goerz merged patch set 9 11/09/19, 16:22