Review main Abandoned

61119[BUGFIX] Avoid regex backtrack escalation in Fluid

Markus Klein CR 0 V 0 Easy +6 −6 updated 07/21/19, 22:39

Commit message

In order to avoid backtrack escalation for inline JS in
Fluid templates this patch wraps potentially affected
JS in a CDATA tag to avoid parsing the JS by Fluid.
This fixes problems with PCRE2 in PHP 7.3.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 710

  1. Markus Klein uploaded patch set 1 06/22/19, 09:44

  2. TYPO3com voted on patch set 1 V +1 06/22/19, 09:55 Completed build in 11m 30s on Sat, 22 Jun, 11:55 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34509

  3. Stephan Großberndt updated the commit message in patch set 2 06/23/19, 15:32

  4. TYPO3com voted on patch set 2 V +1 06/23/19, 15:42 Completed build in 10m 34s on Sun, 23 Jun, 05:42 PM Test Summary: 46477 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34513

  5. Markus Klein uploaded patch set 3 07/18/19, 08:22

  6. Claus Due voted on patch set 3 CR +1 07/18/19, 08:31

  7. TYPO3com voted on patch set 3 V +1 07/18/19, 08:35 Completed build in 12m 04s on Thu, 18 Jul, 10:35 AM Test Summary: 47122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35157

  8. Andreas Kienast voted on patch set 3 CR +1 07/18/19, 08:37

  9. Claus Due commented on patch set 3 CR -1 07/18/19, 08:46

    Has some compatibility issues re: Fluid 2.x / 3.x, trying to come up with a better solution and/or identify a possible but in Fluid 2.x with CDATA being removed. Side note: a better solution here would be to attach the scripts to PageRenderer which could be done with a ViewHelper (that would need to be created).
  10. Markus Klein abandoned the change 07/21/19, 22:39

    Lets hope this will be fixed differently at some point