Review main Merged

61120[BUGFIX] Fix comment in ViewHelper action.link

Joerg Kummer CR +2 V +2 Easy +1 −1 updated 06/24/19, 09:43

Commit message

Correct closing tag in PHP comment example.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Björn Jacob +1
    • Daniel Siepmann +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Björn Jacob +1
    • Daniel Siepmann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Joerg Kummer uploaded patch set 1 06/23/19, 22:23

  2. Joerg Kummer commented on patch set 1 06/23/19, 22:32

    This is the mentioned (#88578) additional fix to already discovered & resolved bug in ViewHelper page.link I used Sybilles change as search-pattern for further occurrences - just found this only one.
  3. TYPO3com voted on patch set 1 V +1 06/23/19, 22:34 Completed build in 11m 04s on Mon, 24 Jun, 12:34 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34514

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 06/24/19, 06:14

  5. Björn Jacob voted on patch set 1 V +1 CR +1 06/24/19, 06:20

  6. Daniel Siepmann voted on patch set 1 V +1 CR +1 06/24/19, 08:05

  7. Oliver Klee voted on patch set 1 CR +1 06/24/19, 09:35

  8. Andreas Kienast voted on patch set 1 V +2 CR +2 06/24/19, 09:43

  9. Andreas Kienast merged patch set 2 06/24/19, 09:43