Review main Merged Breaking

61125[!!!][TASK] Remove AbstractService inheritance from AbstractAuthService

Benni Mack CR +2 V +2 Normal +134 −2 updated 06/28/19, 11:07

Commit message

The current Authentication Service API looks like this:

AbstractService
-> AbstractAuthenticationService
-> AuthenticationService

Most of the functionality of AbstractService is not
used and leads to a confusing PHP inheritance structure,
where most functionality is not needed actually.

Since there are no proper contracts APIs for neither
makeInstanceService / Service API nor Authentication,
the first step is to decouple the logic of both
areas and allow Authentication to continue without
a strong dependency on AbstractService.

This is a pre-patch to decouple Authentication logic
from Service logic.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 69

  1. Benni Mack uploaded patch set 1 06/25/19, 04:23

  2. TYPO3com voted on patch set 1 V -1 06/25/19, 04:36 Completed build in 12m 25s on Tue, 25 Jun, 06:36 AM Test Summary: 4659 of 46829 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34524

  3. Benni Mack uploaded patch set 2 06/25/19, 04:42

  4. TYPO3com voted on patch set 2 V +1 06/25/19, 05:02 Completed build in 16m 42s on Tue, 25 Jun, 07:02 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34526

  5. Benni Mack uploaded patch set 3 06/27/19, 19:56

  6. TYPO3com voted on patch set 3 V +1 06/27/19, 20:08 Completed build in 12m 29s on Thu, 27 Jun, 10:08 PM Test Summary: 46520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34586

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 06/28/19, 09:39

  8. Georg Ringer voted on patch set 3 V +2 CR +2 06/28/19, 11:07

  9. Georg Ringer merged patch set 4 06/28/19, 11:07