Review main Merged

61126[BUGFIX] Use Context API for TemplateService->versionOL

Benni Mack CR +2 V +2 Easy +4 −12 updated 06/27/19, 12:03

Commit message

The Context API can be used now within
TemplateService to fetch a version overlay, which now
only relies on the PageRepository (which also uses Context API),
to avoid certain magic detection of Frontend/Backend mode.

TemplateService is only used to fetch sys_template
records in this use-case.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Daniel Gorges +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack uploaded patch set 1 06/25/19, 04:45

  2. TYPO3com voted on patch set 1 V +1 06/25/19, 05:06 Completed build in 21m 04s on Tue, 25 Jun, 07:06 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34527

  3. Daniel Gorges voted on patch set 1 V +1 CR +1 06/27/19, 10:55

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 06/27/19, 12:03

  5. Daniel Goerz merged patch set 2 06/27/19, 12:03