Review TYPO3_8-7 Merged

61131[SECURITY] Deny pages' TSconfig and tsconfig_includes for non-admins

Oliver Hader CR +2 V +2 Normal +236 −12 updated 06/25/19, 07:19

Commit message

Fields `TSconfig` and `tsconfig_includes` of table `pages` can be
misused by restricted users to contain malicious instructions and
lead to cross-site scripting as well as arbitrary code execution.
Since user input cannot be sanitized properly, the field is now
available for admin users only. In addition directory traversal
in TSconfig static includes has been mitigated.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 10

Review log 34

  1. Oliver Hader uploaded patch set 1 06/25/19, 06:39

  2. Oliver Hader commented on patch set 1 V +2 CR +2 06/25/19, 06:39

    Auto-approved
  3. Oliver Hader merged patch set 2 06/25/19, 06:39

  4. TYPO3com voted on patch set 1 V +1 06/25/19, 07:19 Completed build in 33m 33s on Tue, 25 Jun, 09:19 AM Test Summary: 80366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3557