Review main Merged Breaking

61144[!!!][SECURITY] Disallow session data transfer on frontend user logout

Oliver Hader CR +2 V +2 Easy +14 −4 updated 06/25/19, 08:36

Commit message

When frontend users logged out their session data (e.g. shopping cart)
was transfered into an anonymous session. This session could have been
reused by a different user working with the very same browser.

In order to enhance security aspects on this topic session data is
purged when an according frontend user is logging out. Since this might
be breaking for some scenarios a new feature toggle has been introduced
which allows to keep the previous behavior:

	boolean 'security.frontend.keepSessionDataOnLogout'
	in $GLOBALS['TYPO3_CONF_VARS']['SYS']['features']

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 4

Review log 34

  1. Oliver Hader uploaded patch set 1 06/25/19, 06:41

  2. Oliver Hader commented on patch set 1 V +2 CR +2 06/25/19, 06:42

    Auto-approved
  3. Oliver Hader merged patch set 2 06/25/19, 06:42

  4. TYPO3com voted on patch set 1 V +1 06/25/19, 08:36 Completed build in 1h 50m 02s on Tue, 25 Jun, 10:36 AM Test Summary: 46502 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34534