Review main Merged Breaking

61152[!!!][FEATURE] Replace SwiftMailer with symfony/mailer and symfony/mime

Benni Mack CR +2 V +2 Expert +1221 −822 updated 07/08/19, 13:53

Commit message

SwiftMailer is not in active development anymore
as the author created the successor symfony/mailer
and symfony/mime packages to create and send
emails.

This is a breaking change, as PHP mail() is not
supported anymore. This is now automatically
switched to "sendmail".

In addition \Symfony\Mime\Email has a different
signature than \Swift_Message, which will
cause some trouble, however we've managed
to overcome most of that functionality to
stay backwards-compatible.

Also, all extensions extending from SwiftMailer
will fail as the package is be removed
with this patch.

Spooling has been reimplemented as direct transport
methods (DelayedTransportInterface) instead of
Symfony Messaging for the time being.

Used composer commands:
 * composer require symfony/mailer symfony/mime
 * composer remove swiftmailer/swiftmailer

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 34

Show 14 more files

Review log 2233

Show 48 earlier messages
  1. Benni Mack uploaded patch set 1 06/26/19, 05:26

  2. TYPO3com voted on patch set 1 V -1 06/26/19, 05:38 Completed build in 11m 09s on Wed, 26 Jun, 07:38 AM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34543

  3. Benni Mack uploaded patch set 2 06/26/19, 17:47

  4. Benni Mack uploaded patch set 3 06/26/19, 17:50

  5. TYPO3com voted on patch set 2 V -1 06/26/19, 18:00 Completed build in 12m 49s on Wed, 26 Jun, 08:00 PM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34552

  6. TYPO3com voted on patch set 3 V -1 06/26/19, 18:03 Completed build in 12m 51s on Wed, 26 Jun, 08:03 PM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34553

  7. Benni Mack uploaded patch set 4 06/27/19, 07:43

  8. TYPO3com voted on patch set 4 V -1 06/27/19, 07:55 Completed build in 11m 33s on Thu, 27 Jun, 09:55 AM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34558

  1. Benni Mack rebased onto patch set 5 06/27/19, 09:12

  2. TYPO3com voted on patch set 5 V -1 06/27/19, 09:23 Completed build in 11m 39s on Thu, 27 Jun, 11:23 AM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34559

  3. Oliver Klee commented on patch set 5 06/27/19, 09:24

    I guess this should be marked as WIP, right?
  4. Benni Mack uploaded patch set 6 06/27/19, 09:27

  5. Benni Mack commented on patch set 6 06/27/19, 09:28

    Thx @Oli. done!
  6. TYPO3com voted on patch set 6 V -1 06/27/19, 09:39 Completed build in 11m 35s on Thu, 27 Jun, 11:39 AM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34560

  7. Benni Mack uploaded patch set 7 06/27/19, 10:18

  8. TYPO3com voted on patch set 7 V -1 06/27/19, 10:30 Completed build in 11m 18s on Thu, 27 Jun, 12:30 PM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34562

  9. Benni Mack uploaded patch set 8 06/27/19, 10:50

  10. TYPO3com voted on patch set 8 V -1 06/27/19, 11:02 Completed build in 11m 59s on Thu, 27 Jun, 01:02 PM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34563

  11. Benni Mack uploaded patch set 9 06/27/19, 19:39

  12. TYPO3com voted on patch set 9 V +1 06/27/19, 19:51 Completed build in 11m 09s on Thu, 27 Jun, 09:51 PM Test Summary: 46380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34585

  13. Benni Mack updated the commit message in patch set 10 06/27/19, 19:56

  14. TYPO3com voted on patch set 10 V +1 06/27/19, 20:10 Completed build in 13m 45s on Thu, 27 Jun, 10:10 PM Test Summary: 46380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34587

  15. Georg Ringer commented on patch set 10 06/28/19, 11:14

    EmailLoginNotification.php:87

    this is wrong now

    MailMessage.php:81

    @inheritdoc?

    Feature-88643-NewMailAPIBasedOnSymfonymailerAndSymfonymime.rst:27

    whitespace

    Feature-88643-NewMailAPIBasedOnSymfonymailerAndSymfonymime.rst:40

    should we also mention that FileSpool is experimental yet?
  16. Benni Mack uploaded patch set 11 06/28/19, 13:38

  17. TYPO3com voted on patch set 11 V +1 06/28/19, 13:50 Completed build in 11m 43s on Fri, 28 Jun, 03:50 PM Test Summary: 46386 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34611

  18. Guido Schmechel commented on patch set 11 06/28/19, 14:03

    EmailLoginNotification.php:95

    Maybe Generalutility::trimExplode?
  19. Benni Mack wrote 06/28/19, 14:05

    Description "Edit commit message" removed
  20. Benni Mack commented on patch set 11 06/28/19, 14:06

    EmailLoginNotification.php:87 Reply

    Done

    EmailLoginNotification.php:95 Reply

    This wasn't the case (previously in MailMessage) before either...

    MailMessage.php:81 Reply

    Done

    Feature-88643-NewMailAPIBasedOnSymfonymailerAndSymfonymime.rst:27 Reply

    Done

    Feature-88643-NewMailAPIBasedOnSymfonymailerAndSymfonymime.rst:40 Reply

    Done
  21. Andreas Kienast voted on patch set 11 V +1 CR +1 07/03/19, 16:24

  22. Georg Ringer voted on patch set 11 V +2 CR +2 07/04/19, 07:56

  23. Georg Ringer merged patch set 12 07/04/19, 07:56

  24. Benjamin Franzke commented on patch set 12 07/05/19, 11:39

    SendEmailCommand.php:64 Unresolved

    The SendEmailCommandTest needs to be adapted for this dependency change. CI didn't alert as the tests were skipped with a warning. BUGFIX available in https://review.typo3.org/c/Packages/TYPO3.CMS/+/61233
  25. Susi Moog commented on patch set 12 07/08/19, 13:53

    EmailFinisher.php:109 Unresolved

    this causes a regression as the format is not the same... see https://forge.typo3.org/issues/88702