61152[!!!][FEATURE] Replace SwiftMailer with symfony/mailer and symfony/mime
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Andreas Kienast +1
-
Verified V +2 Done
- Georg Ringer +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 34
- typo3/sysext/backend/Classes/Security/EmailLoginNotification.php4+8 −7
- typo3/sysext/core/Classes/Command/SendEmailCommand.php1+12 −12
- typo3/sysext/core/Classes/Mail/DelayedTransportInterface.phpnew+32 −0
- typo3/sysext/core/Classes/Mail/FileSpool.phpnew+243 −0
- typo3/sysext/core/Classes/Mail/Mailer.php+83 −19
- typo3/sysext/core/Classes/Mail/MailMessage.php2+134 −82
- typo3/sysext/core/Classes/Mail/MboxTransport.php+19 −85
- typo3/sysext/core/Classes/Mail/MemorySpool.php+60 −7
- typo3/sysext/core/Classes/Mail/TransportFactory.php+39 −25
- typo3/sysext/core/Configuration/Commands.php+1 −1
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −1
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Breaking-88643-RemovedSwiftmailerswiftmailerDependency.rstnew+45 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-88643-NewMailAPIBasedOnSymfonymailerAndSymfonymime.rst4new+82 −0
- typo3/sysext/core/Tests/Acceptance/Support/Extension/BackendCoreEnvironment.php+6 −0
- typo3/sysext/core/Tests/Unit/Mail/Fixtures/FakeFileSpoolFixture.php+5 −3
- typo3/sysext/core/Tests/Unit/Mail/Fixtures/FakeInvalidSpoolFixture.php+3 −17
- typo3/sysext/core/Tests/Unit/Mail/Fixtures/FakeTransportFixture.phpdeleted+0 −32
- typo3/sysext/core/Tests/Unit/Mail/Fixtures/FakeValidSpoolFixture.php+11 −15
- typo3/sysext/core/Tests/Unit/Mail/MailerTest.php+17 −15
Show 14 more files
- typo3/sysext/core/Tests/Unit/Mail/MailMessageTest.phpdeleted+0 −227
- typo3/sysext/core/Tests/Unit/Mail/TransportFactoryTest.php+21 −27
- typo3/sysext/core/composer.json+2 −1
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php1+11 −10
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+12 −11
- typo3/sysext/install/Classes/Authentication/AuthenticationService.php+9 −8
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+6 −5
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+21 −0
- typo3/sysext/install/Resources/Private/Templates/Environment/MailTest.html+1 −1
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+10 −12
- typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php+8 −7
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+9 −7
- composer.json+2 −1
- composer.lock+307 −183
Review log 2233
Show 48 earlier messages
-
Benni Mack uploaded patch set 1 06/26/19, 05:26
-
TYPO3com voted on patch set 1 V -1 06/26/19, 05:38 Completed build in 11m 09s on Wed, 26 Jun, 07:38 AM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34543
-
Benni Mack uploaded patch set 2 06/26/19, 17:47
-
Benni Mack uploaded patch set 3 06/26/19, 17:50
-
TYPO3com voted on patch set 2 V -1 06/26/19, 18:00 Completed build in 12m 49s on Wed, 26 Jun, 08:00 PM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34552
-
TYPO3com voted on patch set 3 V -1 06/26/19, 18:03 Completed build in 12m 51s on Wed, 26 Jun, 08:03 PM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34553
-
Benni Mack uploaded patch set 4 06/27/19, 07:43
-
TYPO3com voted on patch set 4 V -1 06/27/19, 07:55 Completed build in 11m 33s on Thu, 27 Jun, 09:55 AM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34558
-
Benni Mack rebased onto patch set 5 06/27/19, 09:12
-
TYPO3com voted on patch set 5 V -1 06/27/19, 09:23 Completed build in 11m 39s on Thu, 27 Jun, 11:23 AM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34559
-
Oliver Klee commented on patch set 5 06/27/19, 09:24
I guess this should be marked as WIP, right? -
Benni Mack uploaded patch set 6 06/27/19, 09:27
-
Benni Mack commented on patch set 6 06/27/19, 09:28
Thx @Oli. done! -
TYPO3com voted on patch set 6 V -1 06/27/19, 09:39 Completed build in 11m 35s on Thu, 27 Jun, 11:39 AM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34560
-
Benni Mack uploaded patch set 7 06/27/19, 10:18
-
TYPO3com voted on patch set 7 V -1 06/27/19, 10:30 Completed build in 11m 18s on Thu, 27 Jun, 12:30 PM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34562
-
Benni Mack uploaded patch set 8 06/27/19, 10:50
-
TYPO3com voted on patch set 8 V -1 06/27/19, 11:02 Completed build in 11m 59s on Thu, 27 Jun, 01:02 PM Test Summary: 1 of 7703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34563
-
Benni Mack uploaded patch set 9 06/27/19, 19:39
-
TYPO3com voted on patch set 9 V +1 06/27/19, 19:51 Completed build in 11m 09s on Thu, 27 Jun, 09:51 PM Test Summary: 46380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34585
-
Benni Mack updated the commit message in patch set 10 06/27/19, 19:56
-
TYPO3com voted on patch set 10 V +1 06/27/19, 20:10 Completed build in 13m 45s on Thu, 27 Jun, 10:10 PM Test Summary: 46380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34587
-
Georg Ringer commented on patch set 10 06/28/19, 11:14
EmailLoginNotification.php:87this is wrong nowMailMessage.php:81@inheritdoc?Feature-88643-NewMailAPIBasedOnSymfonymailerAndSymfonymime.rst:27whitespaceFeature-88643-NewMailAPIBasedOnSymfonymailerAndSymfonymime.rst:40should we also mention that FileSpool is experimental yet? -
Benni Mack uploaded patch set 11 06/28/19, 13:38
-
TYPO3com voted on patch set 11 V +1 06/28/19, 13:50 Completed build in 11m 43s on Fri, 28 Jun, 03:50 PM Test Summary: 46386 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34611
-
Guido Schmechel commented on patch set 11 06/28/19, 14:03
EmailLoginNotification.php:95Maybe Generalutility::trimExplode? -
Benni Mack wrote 06/28/19, 14:05
Description "Edit commit message" removed -
Benni Mack commented on patch set 11 06/28/19, 14:06
EmailLoginNotification.php:87ReplyDoneEmailLoginNotification.php:95ReplyThis wasn't the case (previously in MailMessage) before either...MailMessage.php:81ReplyDoneFeature-88643-NewMailAPIBasedOnSymfonymailerAndSymfonymime.rst:27ReplyDoneFeature-88643-NewMailAPIBasedOnSymfonymailerAndSymfonymime.rst:40ReplyDone -
Andreas Kienast voted on patch set 11 V +1 CR +1 07/03/19, 16:24
-
Georg Ringer voted on patch set 11 V +2 CR +2 07/04/19, 07:56
-
Georg Ringer merged patch set 12 07/04/19, 07:56
-
Benjamin Franzke commented on patch set 12 07/05/19, 11:39
SendEmailCommand.php:64UnresolvedThe SendEmailCommandTest needs to be adapted for this dependency change. CI didn't alert as the tests were skipped with a warning. BUGFIX available in https://review.typo3.org/c/Packages/TYPO3.CMS/+/61233 -
Susi Moog commented on patch set 12 07/08/19, 13:53
EmailFinisher.php:109Unresolvedthis causes a regression as the format is not the same... see https://forge.typo3.org/issues/88702