Review main Merged

61153[BUGFIX] Make files deletable if storage is not browsable

Markus Klein CR +2 V +2 Easy +4 −0 updated 07/21/19, 19:38

Commit message

A check is added to abort the search for a recycler folder
if a storage is not browsable.
An editor wouldn't be able to recover the file anyways as
this requires browsing the storage.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Daniel Goerz +1
    • Johannes Kasberger +1
    • Julian Geils +1
    • Frans Saris +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Johannes Kasberger +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Markus Klein uploaded patch set 1 06/26/19, 12:02

  2. Mathias Brodala updated the commit message in patch set 2 06/26/19, 12:04

  3. TYPO3com voted on patch set 1 V +1 06/26/19, 12:15 Completed build in 12m 50s on Wed, 26 Jun, 02:15 PM Test Summary: 46508 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34548

  4. TYPO3com voted on patch set 2 V +1 06/26/19, 12:17 Completed build in 13m 13s on Wed, 26 Jun, 02:17 PM Test Summary: 46508 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34549

  5. Nicole Hummel commented on patch set 2 06/26/19, 12:29

    ResourceStorage.php:3162

    I think this comment is not correct. A file needs to have a parent folder. But as the storage is not browsable, no subfolders exists.
  6. Markus Klein commented on patch set 2 06/26/19, 13:14

    ResourceStorage.php:3162 Reply

    The parent folder is the root folder, we can't fetch this root folder either. So the comment is correct IMO
  7. Johannes Kasberger voted on patch set 2 V +1 CR +1 06/26/19, 13:17

  8. Benni Mack voted on patch set 2 CR +1 06/26/19, 15:20

  9. Frans Saris voted on patch set 2 CR +1 06/26/19, 19:50

  10. Daniel Goerz voted on patch set 2 CR +1 06/27/19, 12:12

  11. Julian Geils voted on patch set 2 CR +1 07/11/19, 08:24

  12. Benni Mack commented on patch set 2 07/17/19, 05:47

    ResourceStorage.php:3162 Reply

    @Nicole: Should we clarify the comment? Does Markus' feedback solve your concern?
  13. Andreas Kienast voted on patch set 2 CR +1 07/19/19, 09:44

  14. Benjamin Franzke commented on patch set 2 V +2 CR +2 07/21/19, 19:38

    ResourceStorage.php:3162 Reply

    The comment doesn't say that the parent folder does not exist. It says it is not fetchable. That is a crucial difference. Therefore Nicole's (correct) remark "A file needs to have a parent folder" doesn't conflict with this case where it is not fetchable.
  15. Benjamin Franzke merged patch set 3 07/21/19, 19:38