Review main Merged

61154[BUGFIX] Display titles of changelog properly

Daniel Siepmann CR +2 V +2 Normal +36 −36 updated 06/27/19, 12:07

Commit message

As `\`  is escaping, there has to be an additional `\` in front, in
order to display the `\` as expected.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 89

  1. Daniel Siepmann uploaded patch set 1 06/26/19, 16:38

  2. Daniel Siepmann commented on patch set 1 06/26/19, 16:39

    Please check this small Request. It adds escaping to titles of changelog files, in order to display them properly.
  3. TYPO3com voted on patch set 1 V +1 06/26/19, 16:49 Completed build in 10m 51s on Wed, 26 Jun, 06:49 PM Test Summary: 46520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34551

  4. Alexander Schnitzler voted on patch set 1 V +1 CR +1 06/27/19, 07:00

  5. Mathias Brodala commented on patch set 1 CR +1 06/27/19, 07:12

    Personally I'd prefer code formatting for these which would also ensure backslashes are rendered properly. But this is fine too.
  6. Daniel Siepmann commented on patch set 1 06/27/19, 09:52

    > Patch Set 1: Code-Review+1 > > Personally I'd prefer code formatting for these which would also ensure backslashes are rendered properly. But this is fine too. I tried that as first approach. But that doesn't look nice in sidebar and further Navigations. As the PHP code is already highlighted within the text below, I've just escaped. But of course this can be changed.
  7. Mathias Brodala commented on patch set 1 06/27/19, 10:27

    > Patch Set 1: > > > Patch Set 1: Code-Review+1 > > > > Personally I'd prefer code formatting for these which would also ensure backslashes are rendered properly. But this is fine too. > > I tried that as first approach. But that doesn't look nice in sidebar and further Navigations. As the PHP code is already highlighted within the text below, I've just escaped. But of course this can be changed. Alright, thanks for looking into this. :-)
  8. Daniel Goerz voted on patch set 1 V +2 CR +2 06/27/19, 12:07

  9. Daniel Goerz merged patch set 2 06/27/19, 12:07