61155[!!!][TASK] Remove dependencies of TSFE
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Andreas Kienast +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 27
- typo3/sysext/adminpanel/Configuration/RequestMiddlewares.php+3 −3
- typo3/sysext/core/Classes/Http/Uri.php1+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Breaking-88540-ChangedRequestWorkflowForFrontendRequests.rst2+56 −8
- typo3/sysext/core/composer.json1+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+2 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/TypolinkViewHelperTest.php+6 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php3+115 −54
- typo3/sysext/frontend/Classes/Middleware/BackendUserAuthenticator.php+1 −5
- typo3/sysext/frontend/Classes/Middleware/FrontendUserAuthenticator.php+4 −7
- typo3/sysext/frontend/Classes/Middleware/PageArgumentValidator.php1+14 −10
- typo3/sysext/frontend/Classes/Middleware/PageResolver.php+1 −48
- typo3/sysext/frontend/Classes/Middleware/PrepareTypoScriptFrontendRendering.php+4 −4
- typo3/sysext/frontend/Classes/Middleware/ShortcutAndMountPointRedirect.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php3+67 −13
- typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php3+31 −4
- typo3/sysext/frontend/Configuration/RequestMiddlewares.php+39 −33
- typo3/sysext/frontend/Tests/Functional/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+19 −3
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php1+47 −14
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+16 −1
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+2 −3
Show 7 more files
- typo3/sysext/redirects/Classes/Service/RedirectService.php1+7 −3
- typo3/sysext/redirects/Configuration/RequestMiddlewares.php+0 −1
- typo3/sysext/seo/Tests/Functional/Canonical/CanonicalGeneratorTest.php+13 −2
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php+12 −3
- typo3/sysext/workspaces/Configuration/RequestMiddlewares.php+4 −3
- composer.json+1 −1
- composer.lock+6 −6
Review log 2645
Show 1020 earlier messages
-
Benni Mack uploaded patch set 1 06/26/19, 21:06
-
TYPO3com voted on patch set 1 V -1 06/26/19, 21:16 Completed build in 09m 46s on Wed, 26 Jun, 11:16 PM Test Summary: 4277 of 46871 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34554
-
Benni Mack uploaded patch set 2 07/02/19, 16:39
-
TYPO3com voted on patch set 2 V -1 07/02/19, 16:55 Completed build in 15m 45s on Tue, 2 Jul, 06:55 PM Test Summary: 5090 of 47203 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34717
-
Benni Mack uploaded patch set 3 07/03/19, 18:20
-
TYPO3com voted on patch set 3 V -1 07/03/19, 18:31 Completed build in 11m 07s on Wed, 3 Jul, 08:31 PM Test Summary: 775 of 47203 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34758
-
Benni Mack uploaded patch set 4 07/04/19, 06:41
-
TYPO3com voted on patch set 4 V -1 07/04/19, 06:51 Completed build in 10m 17s on Thu, 4 Jul, 08:51 AM Test Summary: 667 of 47203 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34763
-
Benni Mack uploaded patch set 5 07/04/19, 07:50
-
TYPO3com voted on patch set 5 V -1 07/04/19, 07:50 Completed build in 16s on Thu, 4 Jul, 09:50 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34764
-
Benni Mack uploaded patch set 6 07/04/19, 07:52
-
TYPO3com voted on patch set 6 V -1 07/04/19, 08:03 Completed build in 10m 32s on Thu, 4 Jul, 10:03 AM Test Summary: 551 of 47203 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34765
-
Benni Mack updated the commit message in patch set 7 07/11/19, 06:56
-
TYPO3com voted on patch set 7 V -1 07/11/19, 07:07 Completed build in 10m 52s on Thu, 11 Jul, 09:07 AM Test Summary: 551 of 47097 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34895
-
Benni Mack uploaded patch set 8 07/11/19, 12:20
-
TYPO3com voted on patch set 8 V -1 07/11/19, 12:36 Completed build in 15m 45s on Thu, 11 Jul, 02:36 PM Test Summary: 473 of 47349 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34910
-
Benni Mack uploaded patch set 9 07/11/19, 13:00
-
TYPO3com voted on patch set 9 V -1 07/11/19, 13:37 Completed build in 37m 00s on Thu, 11 Jul, 03:37 PM Test Summary: 278 of 47341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34918
-
Benni Mack uploaded patch set 10 07/11/19, 14:12
-
TYPO3com voted on patch set 10 V -1 07/11/19, 14:23 Completed build in 11m 26s on Thu, 11 Jul, 04:23 PM Test Summary: 113 of 47341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34922
-
Benni Mack uploaded patch set 11 07/11/19, 17:15
-
TYPO3com voted on patch set 11 V -1 07/11/19, 17:26 Completed build in 11m 07s on Thu, 11 Jul, 07:26 PM Test Summary: 113 of 47341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34927
-
Benni Mack uploaded patch set 12 07/11/19, 18:28
-
TYPO3com voted on patch set 12 V -1 07/11/19, 18:40 Completed build in 12m 14s on Thu, 11 Jul, 08:40 PM Test Summary: 113 of 47341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34929
-
Benni Mack uploaded patch set 13 07/11/19, 19:00
-
TYPO3com voted on patch set 13 V -1 07/11/19, 19:12 Completed build in 11m 42s on Thu, 11 Jul, 09:12 PM Test Summary: 26 of 47341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34932
-
Benni Mack uploaded patch set 14 07/11/19, 19:23
-
TYPO3com voted on patch set 14 V -1 07/11/19, 19:39 Completed build in 15m 09s on Thu, 11 Jul, 09:39 PM Test Summary: 2 of 47341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34937
-
Benni Mack uploaded patch set 15 07/11/19, 19:57
-
TYPO3com voted on patch set 15 V +1 07/11/19, 20:08 Completed build in 10m 32s on Thu, 11 Jul, 10:08 PM Test Summary: 46978 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34938
-
Benni Mack uploaded patch set 16 07/13/19, 10:49
-
Benni Mack updated the commit message in patch set 17 07/13/19, 10:49
-
TYPO3com voted on patch set 16 V +1 07/13/19, 11:02 Completed build in 13m 17s on Sat, 13 Jul, 01:02 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34984
-
TYPO3com voted on patch set 17 V +1 07/13/19, 11:03 Completed build in 14m 03s on Sat, 13 Jul, 01:03 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34985
-
Benni Mack uploaded patch set 18 07/13/19, 12:20
-
Oliver Klee commented on patch set 18 07/13/19, 12:23
composer.json:57UnresolvedIs this temporary?TypoScriptFrontendController.php:711Can we extract these code blocks to methods? Then we can use speaking method names (and PHPDoc descriptions) instead of the comments.TypoScriptFrontendController.php:712UnresolvedThis additional pair of parenthesis is not needed.TypoScriptFrontendInitialization.php:55UnresolvedThe additional pair of parenthesis is not needed here.TypoScriptFrontendInitialization.php:100Unresolved?BackendUserAuthenticationTypoScriptFrontendInitialization.php:102Unresolved: voidAbstractTypolinkBuilder.php:219UnresolvedThe additional pair of parenthesis is not needed here.AbstractTypolinkBuilder.php:222UnresolvedDitto.AbstractTypolinkBuilder.php:227UnresolvedDitto.ContentObjectRendererTest.php:38UnresolvedThis can even be more specific: array[]RedirectService.php:290UnresolvedWhy the pair of parenthesis? -
TYPO3com voted on patch set 18 V +1 07/13/19, 12:33 Completed build in 13m 20s on Sat, 13 Jul, 02:33 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34990
-
Andreas Kienast commented on patch set 18 07/13/19, 12:39
PageArgumentValidator.php:81UnresolvedI'm not sure about this. If I understand it correctly, having "disableNoCacheParameter" parameter enabled *and* having no_cache set to true would still disable caching. Is this intended? -
Anja Leichsenring commented on patch set 18 07/13/19, 12:52
Breaking-88540-ChangedRequestWorkflowForFrontendRequests.rst:35Unresolvedindependent of ... what? the sentence is unfinished.Breaking-88540-ChangedRequestWorkflowForFrontendRequests.rst:81Unresolvedthis looks incomplete or duplicated by the following sentence. -
Benni Mack uploaded patch set 19 07/13/19, 13:07
-
Benni Mack commented on patch set 19 07/13/19, 13:08
Thanks everybody, tried to incorporate all of your feedback.TypoScriptFrontendController.php:711Reply Unresolvedthought about that too, but then I thought: 1. This is part of the migration path / deprecation part for v10, in v11, this will result in simple constructor injection then. 2. If I split this up, trigger_error and Exceptions will be bubbled into custom methods, don't know if this would result in more complex know how for developers. Any ideas? -
TYPO3com voted on patch set 19 V +1 07/13/19, 13:18 Completed build in 10m 51s on Sat, 13 Jul, 03:18 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34992
-
Anja Leichsenring voted on patch set 19 V +1 CR +1 07/13/19, 13:30
-
Andreas Kienast voted on patch set 19 V +2 CR +2 07/13/19, 13:43
-
Andreas Kienast merged patch set 20 07/13/19, 13:43
Uri.php:123Unresolved