Review main Merged Breaking

61158[!!!][TASK] Remove "sys_template.nextLevel"

Benni Mack CR +2 V +2 Normal +51 −61 updated 06/28/19, 15:35

Commit message

The special handling "nextLevel" in TypoScript templates
to only load a specific sys_template on the next level (subpages and
further down the rootline) but not on the current level,
is removed.

It is recommended to use proper inclusions and TypoScript
conditions instead.

This reduces complexity within the TemplateService parser,
and for newcomers a very confusing option after gathering
some feedback on this topic.

The database field "sys_template.nextLevel" is therefore
removed.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 810

  1. Benni Mack uploaded patch set 1 06/27/19, 12:43

  2. TYPO3com voted on patch set 1 V +1 06/27/19, 13:05 Completed build in 18m 08s on Thu, 27 Jun, 03:05 PM Test Summary: 46520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34572

  3. Benni Mack uploaded patch set 2 06/27/19, 14:25

  4. TYPO3com voted on patch set 2 V +1 06/27/19, 14:36 Completed build in 11m 10s on Thu, 27 Jun, 04:36 PM Test Summary: 46520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34577

  5. Benjamin Kott voted on patch set 2 CR +1 06/27/19, 16:03

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 06/28/19, 07:41

  7. Georg Ringer commented on patch set 2 06/28/19, 11:09

    Breaking-88640-DatabaseFieldSys_templatenextLevelAndTypoScriptSublevel-InheritanceRemoved.rst:43

    should we do an update wizard which checks that so that integrators don't forget to change the TS?
  8. Benni Mack commented on patch set 2 06/28/19, 12:48

    Breaking-88640-DatabaseFieldSys_templatenextLevelAndTypoScriptSublevel-InheritanceRemoved.rst:43 Reply Unresolved

    my main issue was that we cannot upgrade them by an automatic action.
  9. Daniel Goerz voted on patch set 2 V +2 CR +2 06/28/19, 15:35

  10. Daniel Goerz merged patch set 3 06/28/19, 15:35