Review 9.5 Merged

61159[BUGFIX] Decouple ColorPicker from FormEngine

Daniel Goerz CR +2 V +2 Easy +4 −5 updated 08/02/19, 18:37

Commit message

Since #87031 the color picker is tightly coupled to FormEngine, causing
issues if not used in FormEngine context, e.g. in Constant Editor.

This patch removes the introduced FormEngine handling and uses minicolors'
events to fix the original reported bug.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 58

  1. Daniel Goerz uploaded patch set 1 06/27/19, 13:31

  2. Daniel Goerz commented on patch set 1 06/27/19, 13:31

    manual backport
  3. TYPO3com voted on patch set 1 V +1 06/27/19, 13:51 Completed build in 15m 27s on Thu, 27 Jun, 03:51 PM Test Summary: 50467 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-839

  4. Andreas Kienast rebased onto patch set 2 08/02/19, 18:14

  5. TYPO3com voted on patch set 2 V -1 08/02/19, 18:25 Completed build in 11m 12s on Fri, 2 Aug, 06:25 PM Test Summary: 9 of 50997 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-942

  6. TYPO3com voted on patch set 2 V +1 08/02/19, 18:30 Completed build in 26m 39s on Fri, 2 Aug, 06:30 PM Test Summary: 50529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-942

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 08/02/19, 18:37

  8. Andreas Kienast merged patch set 3 08/02/19, 18:37