Review main Merged

61162[BUGFIX] Add documentation for site-language base variants

Benni Mack CR +2 V +2 Normal +63 −1 updated 06/28/19, 10:31

Commit message

Since bugfix #87831 it is possible to also add base variants
for specific languages, however this was not documented.

See

https://review.typo3.org/c/Packages/TYPO3.CMS/+/59840

for the related change.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1215

  1. Benni Mack uploaded patch set 1 06/27/19, 20:17

  2. Benni Mack commented on patch set 2 06/27/19, 20:18

    Published edit on patch set 1.
  3. Jonas Eberle voted on patch set 2 V +1 06/27/19, 20:29

  4. TYPO3com voted on patch set 1 V +1 06/27/19, 20:30 Completed build in 13m 23s on Thu, 27 Jun, 10:30 PM Test Summary: 46520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34588

  5. TYPO3com voted on patch set 2 V +1 06/27/19, 20:33 Completed build in 14m 36s on Thu, 27 Jun, 10:33 PM Test Summary: 46520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34589

  6. Richard Haeser voted on patch set 2 CR +1 06/27/19, 22:30

  7. Björn Jacob commented on patch set 2 CR -1 06/28/19, 05:21

    "based"

    Feature-86303-VariantsForSitesBase.rst:34

    "German"
  8. Daniel Goerz commented on patch set 3 06/28/19, 10:16

    Published edit on patch set 2.
  9. Daniel Goerz commented on patch set 3 06/28/19, 10:16

    Reply

    base variants is correct here. The topic is "base variants"
  10. Daniel Goerz commented on patch set 3 06/28/19, 10:17

    Reply

    Done

    Feature-86303-VariantsForSitesBase.rst:34 Reply

    Done
  11. Daniel Goerz voted on patch set 3 V +1 CR +1 06/28/19, 10:17

  12. Björn Jacob commented on patch set 3 V +1 CR +1 06/28/19, 10:18

    Sry, you are right @Daniel :/
  13. TYPO3com voted on patch set 3 V +1 06/28/19, 10:29 Completed build in 12m 52s on Fri, 28 Jun, 12:29 PM Test Summary: 46520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34601

  14. Daniel Goerz voted on patch set 3 V +2 CR +2 06/28/19, 10:31

  15. Daniel Goerz merged patch set 4 06/28/19, 10:31