Review main Merged

61165[BUGFIX] Check if title is provided before accessing it

Georg Ringer CR +2 V +2 Easy +4 −3 updated 07/10/19, 15:44

Commit message

If no title is provided for a table in the TCA (ctrl|title),
the wizard for creating new records must not fail with an
exception.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Julian Geils +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Julian Geils +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1316

  1. Georg Ringer uploaded patch set 1 06/28/19, 11:51

  2. Georg Ringer commented on patch set 1 06/28/19, 11:52

    This change is ready for review.
  3. Oliver Klee commented on patch set 1 06/28/19, 11:55

    Can we mention what part of the core is affected (or which title)?

    NewRecordController.php:582 Unresolved

    Does the problem occur because it is something other than a string, or because it is not set? For the latter case, isset() would be more fitting.
  4. TYPO3com voted on patch set 1 V +1 06/28/19, 12:02 Completed build in 10m 54s on Fri, 28 Jun, 02:02 PM Test Summary: 46517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34607

  5. Daniel Goerz updated the commit message in patch set 2 07/01/19, 18:47

  6. Daniel Goerz commented on patch set 2 07/01/19, 18:47

    Reply

    Done
  7. TYPO3com voted on patch set 2 V +1 07/01/19, 18:59 Completed build in 11m 58s on Mon, 1 Jul, 08:59 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34701

  8. Oliver Klee voted on patch set 2 CR +1 07/01/19, 20:00

  9. Alexander Schnitzler commented on patch set 2 07/02/19, 14:38

    NewRecordController.php:582

    If checking for a string I'd recommend checking if the variable is set at all with isset before. Alternatively we can introduce a local variable like this: $title = (string)($v['ctrl']['title'] ?? '') That way we are sure the title is set and is of type string.
  10. Jörg Bösche commented on patch set 2 07/09/19, 09:22

    NewRecordController.php:582 Reply

    Done
  11. Jörg Bösche uploaded patch set 3 07/09/19, 09:24

  12. TYPO3com voted on patch set 3 V +1 07/09/19, 09:34 Completed build in 10m 02s on Tue, 9 Jul, 11:34 AM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34855

  13. Oliver Klee voted on patch set 3 CR +1 07/09/19, 09:48

  14. Julian Geils voted on patch set 3 V +1 CR +1 07/10/19, 08:47

  15. Benjamin Franzke voted on patch set 3 V +2 CR +2 07/10/19, 15:44

  16. Benjamin Franzke merged patch set 4 07/10/19, 15:44