61165[BUGFIX] Check if title is provided before accessing it
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Julian Geils +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Julian Geils +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1316
-
Georg Ringer uploaded patch set 1 06/28/19, 11:51
-
Georg Ringer commented on patch set 1 06/28/19, 11:52
This change is ready for review. -
Oliver Klee commented on patch set 1 06/28/19, 11:55
Can we mention what part of the core is affected (or which title)?NewRecordController.php:582UnresolvedDoes the problem occur because it is something other than a string, or because it is not set? For the latter case, isset() would be more fitting. -
TYPO3com voted on patch set 1 V +1 06/28/19, 12:02 Completed build in 10m 54s on Fri, 28 Jun, 02:02 PM Test Summary: 46517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34607
-
Daniel Goerz updated the commit message in patch set 2 07/01/19, 18:47
-
Daniel Goerz commented on patch set 2 07/01/19, 18:47
Reply
Done -
TYPO3com voted on patch set 2 V +1 07/01/19, 18:59 Completed build in 11m 58s on Mon, 1 Jul, 08:59 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34701
-
Oliver Klee voted on patch set 2 CR +1 07/01/19, 20:00
-
Alexander Schnitzler commented on patch set 2 07/02/19, 14:38
NewRecordController.php:582If checking for a string I'd recommend checking if the variable is set at all with isset before. Alternatively we can introduce a local variable like this: $title = (string)($v['ctrl']['title'] ?? '') That way we are sure the title is set and is of type string. -
Jörg Bösche commented on patch set 2 07/09/19, 09:22
NewRecordController.php:582ReplyDone -
Jörg Bösche uploaded patch set 3 07/09/19, 09:24
-
TYPO3com voted on patch set 3 V +1 07/09/19, 09:34 Completed build in 10m 02s on Tue, 9 Jul, 11:34 AM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34855
-
Oliver Klee voted on patch set 3 CR +1 07/09/19, 09:48
-
Julian Geils voted on patch set 3 V +1 CR +1 07/10/19, 08:47
-
Benjamin Franzke voted on patch set 3 V +2 CR +2 07/10/19, 15:44
-
Benjamin Franzke merged patch set 4 07/10/19, 15:44