Review main Merged

61166[TASK] Move PageRepository to EXT:core

Benni Mack CR +2 V +2 Hard +217 −103 updated 07/17/19, 05:12

Commit message

Since Context API was introduced in TYPO3 v9, PageRepository is highly
decoupled from $TSFE->sys_page, and fully works standalone.

It is also used in various places where TSFE is not needed,
or required, but also in places of EXT:core.

Especially parts like RootlineUtility, which depends on PageRepository
very much, cannot live without it.

I propose to move this highly important PHP class into EXT:core,
in order to allow to decouple EXT:frontend even further from
EXT:core.

The FQCN is moved from
- \TYPO3\CMS\Frontend\Page\PageRepository
to
- TYPO3\CMS\Core\Domain\Repository\PageRepository

It can be assumed to use PageRepository for any use-case
and actually reduce usages towards BackendUtility::get...
by using this API more and more.

Further adaptions could be to reduce the logic
within PageRepository and move this into QueryBuilder
and assimilate especially the "versionOL" behavior.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 64

Show 44 more files

Review log 1117

  1. Benni Mack uploaded patch set 1 06/28/19, 14:32

  2. TYPO3com voted on patch set 1 V -1 06/28/19, 14:42 Completed build in 09m 32s on Fri, 28 Jun, 04:42 PM Test Summary: 66 of 47185 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34616

  3. Benni Mack uploaded patch set 2 07/01/19, 11:08

  4. TYPO3com voted on patch set 2 V +1 07/01/19, 11:22 Completed build in 14m 18s on Mon, 1 Jul, 01:22 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34682

  5. Benni Mack uploaded patch set 3 07/13/19, 14:14

  6. TYPO3com voted on patch set 3 V -1 07/13/19, 14:23 Completed build in 09m 26s on Sat, 13 Jul, 04:23 PM Test Summary: 4763 of 47361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34996

  7. Benni Mack uploaded patch set 4 07/13/19, 14:27

  8. TYPO3com voted on patch set 4 V +1 07/13/19, 14:38 Completed build in 11m 26s on Sat, 13 Jul, 04:38 PM Test Summary: 46997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34998

  9. Benni Mack uploaded patch set 5 07/13/19, 16:55

  10. TYPO3com voted on patch set 5 V +1 07/13/19, 17:07 Completed build in 11m 51s on Sat, 13 Jul, 07:07 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35007

  11. Oliver Klee voted on patch set 5 CR +1 07/14/19, 10:57

  12. Benni Mack uploaded patch set 6 07/16/19, 15:14

  13. TYPO3com voted on patch set 6 V +1 07/16/19, 15:25 Completed build in 11m 08s on Tue, 16 Jul, 05:25 PM Test Summary: 47118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35103

  14. Oliver Klee voted on patch set 6 CR +1 07/16/19, 16:51

  15. Georg Ringer voted on patch set 6 V +1 CR +1 07/16/19, 18:10

  16. Benjamin Franzke voted on patch set 6 V +2 CR +2 07/17/19, 05:12

  17. Benjamin Franzke merged patch set 7 07/17/19, 05:12