Review main Merged

61171[BUGFIX] Respect config.disablePreviewNotification

Gerrit Mohrmann CR +2 V +2 Easy +1 −1 updated 07/13/19, 17:24

Commit message

In TYPO3\CMS\Frontend\Hooks\FrontendHooks->displayPreviewInfoMessage()
is now checked, that the config.disablePreviewNotification is set.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Julian Geils +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Gerrit Mohrmann uploaded patch set 1 06/29/19, 12:18

  2. TYPO3com voted on patch set 1 V +1 06/29/19, 12:30 Completed build in 11m 46s on Sat, 29 Jun, 02:30 PM Test Summary: 46832 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34641

  3. Jörg Bösche voted on patch set 1 V +1 CR +1 07/08/19, 14:17

  4. Benjamin Franzke uploaded patch set 2 07/08/19, 20:57

  5. Benjamin Franzke voted on patch set 2 V +1 CR +1 07/08/19, 20:59

  6. TYPO3com voted on patch set 2 V +1 07/08/19, 21:07 Completed build in 09m 15s on Mon, 8 Jul, 11:07 PM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34849

  7. Julian Geils voted on patch set 2 CR +1 07/09/19, 07:54

  8. Benni Mack voted on patch set 2 CR +2 07/09/19, 13:19

  9. Benni Mack voted on patch set 2 V +2 07/13/19, 17:24

  10. Benni Mack merged patch set 3 07/13/19, 17:24