61192[BUGFIX] Remove set fe_user groups to null when previewing
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1922
-
Gerrit Mohrmann uploaded patch set 1 06/29/19, 12:24
-
TYPO3com voted on patch set 1 V +1 06/29/19, 12:38 Completed build in 12m 06s on Sat, 29 Jun, 02:38 PM Test Summary: 46832 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34643
-
Björn Jacob commented on patch set 1 07/01/19, 05:13
-
Gerrit Mohrmann updated the commit message in patch set 2 07/01/19, 17:03
-
Björn Jacob voted on patch set 2 CR +1 07/01/19, 17:11
-
TYPO3com voted on patch set 2 V +1 07/01/19, 17:15 Completed build in 10m 58s on Mon, 1 Jul, 07:15 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34695
-
Benni Mack voted on patch set 2 CR +1 07/11/19, 04:35
-
Jörg Bösche voted on patch set 2 CR +1 07/11/19, 06:38
-
Benni Mack commented on patch set 2 08/21/19, 14:44
Hey Gerrit. How about we make this master only? Is that OK with you? -
Oliver Klee commented on patch set 2 08/21/19, 17:46
TypoScriptFrontendController.php:867We still should keep an @return annotation (with the correct type). In this case (with the current code), this would be @return null|void. Or we change the "return null" to "return" and don't re-add the @return annotation. -
Gerrit Mohrmann commented on patch set 2 08/22/19, 11:21
> Patch Set 2: > > Hey Gerrit. How about we make this master only? Is that OK with you? Because the patch is fixing accessing restricted pages in the frontend, I think it would be nice to have it in v9. -
Gerrit Mohrmann uploaded patch set 3 08/22/19, 12:20
-
TYPO3com voted on patch set 3 V +1 08/22/19, 12:37 Completed build in 13m 03s on Thu, 22 Aug, 12:37 PM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35766
-
Benni Mack voted on patch set 3 V +1 CR +1 09/11/19, 14:01
-
Henning Liebe voted on patch set 3 CR +1 10/08/19, 08:58
-
Sascha Rademacher voted on patch set 3 CR +1 10/08/19, 09:20
-
Felix P. voted on patch set 3 CR +1 10/08/19, 12:31
-
Julian Geils voted on patch set 3 CR +1 10/08/19, 13:38
-
Jörg Bösche commented on patch set 3 CR +1 10/10/19, 12:28
The code looks good to me, but I am not able to reproduce an frontend error output with the steps written in the description of #88654. - Finally it is not possible for me to verify the bugfix or is this only a code cleanup ticket and does not depend to the described issue anymore? -
Gerrit Mohrmann commented on patch set 3 10/13/19, 22:54
> Patch Set 3: Code-Review+1 > > The code looks good to me, but I am not able to reproduce an frontend error output with the steps written in the description of #88654. - Finally it is not possible for me to verify the bugfix or is this only a code cleanup ticket and does not depend to the described issue anymore? I can only speak for the v9 branch. There it is a bugfix. Maybe test it with the f:security.ifHasRole ViewHelper.TypoScriptFrontendController.php:867Reply Unresolved> Or we change the "return null" to "return" and don't re-add the @return annotation. Ah missed that, I would remove the null. -
Daniel Goerz commented on patch set 3 01/22/20, 11:26
Is this patch still valid after https://review.typo3.org/c/Packages/TYPO3.CMS/+/59927? If yes: please rebase and merge If no: Please abandon -
Susi Moog abandoned the change 01/25/20, 10:18
see https://review.typo3.org/c/Packages/TYPO3.CMS/+/59927 - the code is in fact still necessary as it was a mistake that previewing only worked with the admin panel.
Unresolved