Review main Merged

61194[BUGFIX] Reenable input field for page ID when setting a link via RTE

Ioulia Kondratovitch CR +2 V +2 Easy +1 −1 updated 11/09/19, 13:05

Commit message

Remove obsolete dot to make following setting work again:
RTE.default.buttons.link.pageIdSelector.enabled = 1

This now renders an input field for a page ID again when setting
a link via RTE.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2229

Show 24 earlier messages
  1. Ioulia Kondratovitch uploaded patch set 1 06/29/19, 20:49

  2. TYPO3com voted on patch set 1 V +1 06/29/19, 20:59 Completed build in 10m 21s on Sat, 29 Jun, 10:59 PM Test Summary: 46832 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34648

  3. Ioulia Kondratovitch updated the commit message in patch set 2 06/29/19, 21:01

  4. TYPO3com voted on patch set 2 V +1 06/29/19, 21:11 Completed build in 09m 50s on Sat, 29 Jun, 11:11 PM Test Summary: 46832 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34649

  1. Andreas Kienast updated the commit message in patch set 3 06/30/19, 06:28

  2. Andreas Kienast voted on patch set 3 V +1 CR +1 06/30/19, 06:28

  3. TYPO3com voted on patch set 3 V +1 06/30/19, 06:39 Completed build in 11m 24s on Sun, 30 Jun, 08:39 AM Test Summary: 46831 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34654

  4. Riccardo De Contardi commented on patch set 3 V +1 06/30/19, 07:27

    after patch applying, the field with ID select appears on RTE link wizard; the link is created es e.g. `<a href="77">` and works on frontend
  5. Riccardo De Contardi commented on patch set 3 06/30/19, 07:28

    > Patch Set 3: Verified+1 > > after patch applying, the field with ID select appears on RTE link wizard; the link is created es e.g. `<a href="77">` and works on frontend I forgot: #83056 is not solved; the selector only appears on RTE
  6. Björn Jacob commented on patch set 3 07/01/19, 04:55

    I'd prefer "input field". No reason for a hyphen.
    "setting"
    See above.
  7. Daniel Goerz commented on patch set 3 07/01/19, 07:40

    If I understand everything correctly this issue is not solved with this patch
  8. Daniel Goerz updated the commit message in patch set 4 07/01/19, 07:42

  9. Daniel Goerz commented on patch set 4 07/01/19, 07:42

    Unresolved

    Also not sure if this should go into 8.7, does not seem critical to me
  10. Daniel Goerz commented on patch set 4 07/01/19, 07:43

    Reply

    Done

    Reply

    Done

    Reply

    Done

    Reply

    Done
  11. TYPO3com voted on patch set 4 V +1 07/01/19, 07:53 Completed build in 11m 00s on Mon, 1 Jul, 09:53 AM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34665

  12. Daniel Goerz updated the commit message in patch set 5 07/01/19, 08:00

  13. Daniel Goerz commented on patch set 5 V +1 CR +1 07/01/19, 08:01

    Checked with Benni, this does not seem relevant for 8.7 which is in critical bugfix mode
  14. TYPO3com voted on patch set 5 V +1 07/01/19, 08:15 Completed build in 12m 16s on Mon, 1 Jul, 10:15 AM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34669

  15. Björn Jacob voted on patch set 5 CR +1 07/01/19, 08:16

  16. Daniel Windloff commented on patch set 5 V -1 07/05/19, 09:28

    The input field is enabled with the patch. But the created link is <a href="<pageUid>"> instead of <a href="t3://page?uid=<pageUid>">
  17. Daniel Goerz voted on patch set 5 V 0 CR 0 07/05/19, 09:41

  18. Ioulia Kondratovitch commented on patch set 5 V +1 CR +1 10/27/19, 10:49

    > Patch Set 5: Verified-1 > > The input field is enabled with the patch. > But the created link is <a href="<pageUid>"> instead of <a href="t3://page?uid=<pageUid>"> I have just rechecked this with 9.5.11-dev and with master. The link is set correctly, as soon as you klick "save" on the content element with RTE. 1. After setting the link, before saving: <a href="1">link via pid</a> 2. After saving: <a href="t3://page?uid=1">link via pid</a>
  19. Oliver Gassner commented on patch set 5 V +1 CR +1 10/30/19, 11:04

    works.
  20. Daniel Goerz updated the commit message in patch set 6 11/09/19, 11:35

  21. Daniel Goerz voted on patch set 6 V +1 CR +1 11/09/19, 11:35

  22. TYPO3com voted on patch set 6 V -1 11/09/19, 11:58 Completed build in 16m 58s on Sat, 9 Nov, 11:58 AM Test Summary: 9 of 48537 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38157

  23. TYPO3com voted on patch set 6 V +1 11/09/19, 12:02 Completed build in 38m 12s on Sat, 9 Nov, 12:02 PM Test Summary: 48178 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38157

  24. Susi Moog voted on patch set 6 V +2 CR +2 11/09/19, 13:05

  25. Susi Moog merged patch set 7 11/09/19, 13:05