Review main Merged Breaking

61195[!!!][TASK] Drop FormEngine popup configuration

Andreas Kienast CR +2 V +2 Normal +37 −43 updated 07/05/19, 10:19

Commit message

The options `options.popupWindowSize` and `options.rte.popupWindowSize`
used to configure popup sizes have been removed.

Most of the popups are rendered as modals that don't allow configured
sizes, the remaining popups have hardcoded sizes.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Björn Jacob +1
    • Johannes Seipelt +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 810

  1. Andreas Kienast uploaded patch set 1 06/30/19, 06:14

  2. Andreas Kienast voted on patch set 1 CR -1 06/30/19, 06:19

  3. Andreas Kienast uploaded patch set 2 06/30/19, 06:23

  4. TYPO3com voted on patch set 1 V +1 06/30/19, 06:24 Completed build in 09m 54s on Sun, 30 Jun, 08:24 AM Test Summary: 46832 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34652

  5. TYPO3com voted on patch set 2 V +1 06/30/19, 06:34 Completed build in 11m 05s on Sun, 30 Jun, 08:34 AM Test Summary: 46832 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34653

  6. Björn Jacob voted on patch set 2 CR +1 07/01/19, 04:57

  7. Daniel Goerz voted on patch set 2 V +1 CR +1 07/05/19, 08:32

  8. Johannes Seipelt voted on patch set 2 CR +1 07/05/19, 10:15

  9. Anja Leichsenring voted on patch set 2 V +2 CR +2 07/05/19, 10:18

  10. Anja Leichsenring merged patch set 3 07/05/19, 10:19