61199[BUGFIX] Use all available languages from all sites for permissions
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Georg Ringer +1
- Frank Nägler +1
- Andreas Kienast +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Georg Ringer +1
- Riccardo De Contardi +1
- Frank Nägler +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1620
-
Benni Mack uploaded patch set 1 07/01/19, 07:46
-
TYPO3com voted on patch set 1 V -1 07/01/19, 07:58 Completed build in 11m 05s on Mon, 1 Jul, 09:58 AM Test Summary: 10 of 47199 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34666
-
Riccardo De Contardi commented on patch set 1 V +1 07/01/19, 19:09
Tested with both BE user and BE usergroup; I see that for each language, the sites that are using it are listed - nice touch. -
Benni Mack uploaded patch set 2 07/02/19, 16:47
-
TYPO3com voted on patch set 2 V -1 07/02/19, 16:57 Completed build in 09m 30s on Tue, 2 Jul, 06:57 PM Test Summary: 6 of 47203 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34718
-
Benni Mack uploaded patch set 3 07/03/19, 18:35
-
TYPO3com voted on patch set 3 V -1 07/03/19, 18:35 Completed build in 12s on Wed, 3 Jul, 08:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34760
-
Benni Mack uploaded patch set 4 07/03/19, 18:36
-
TYPO3com voted on patch set 4 V +1 07/03/19, 18:46 Completed build in 09m 47s on Wed, 3 Jul, 08:46 PM Test Summary: 46840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34761
-
Riccardo De Contardi commented on patch set 4 V +1 07/03/19, 19:25
Tested with both BE user and BE usergroup. -
Oliver Klee commented on patch set 4 07/03/19, 20:11
AbstractItemProvider.php:278Wow, this is long … I propose we extract this to a separate, well-named method. -
Benni Mack commented on patch set 4 07/04/19, 06:36
AbstractItemProvider.php:278ReplyYeah, if you look at the whole switch/case construct, the whole method is super-long. At first I felt like "OK, let's first clean this up" but then I thought - OK, let's first fix the issue and then do a separate clean up later-on. OK with you? -
Georg Ringer voted on patch set 4 V +1 CR +1 07/04/19, 06:38
-
Oliver Klee commented on patch set 4 07/04/19, 09:41
AbstractItemProvider.php:278Reply UnresolvedI was thinking along the lines of putting the _new_ code into a separate method (as far as possible) so that at least the code does not get worse from the change. (This is the "campsite rule": A change to the code should not leave the code in a worse shape than before.) -
Anja Leichsenring commented on patch set 4 V -1 07/05/19, 14:06
now the default language is not available anymore in BEgroup setup ... -
Anja Leichsenring commented on patch set 4 V 0 07/05/19, 14:10
> Patch Set 4: Verified-1 > > now the default language is not available anymore in BEgroup setup ... all right, glasses please .... there is no item 'default language' anymore, but the language got the proper name. -
Andreas Kienast voted on patch set 4 V +1 CR +1 07/05/19, 14:14
-
Anja Leichsenring voted on patch set 4 V +2 CR +2 07/05/19, 14:15
-
Anja Leichsenring merged patch set 5 07/05/19, 14:15
-
Frank Nägler voted on patch set 5 V +1 CR +1 07/05/19, 14:15