61202[TASK] Split ImportExportController
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jörg Bösche +1
-
Verified V +2 Done
- Benni Mack +2
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 13
- Build/Sources/TypeScript/impexp/Resources/Public/TypeScript/ContextMenuActions.ts+5 −7
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+1 −2
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-88662-DeprecatedBackendRouteXMOD_tximpexp.rstnew+35 −0
- typo3/sysext/impexp/Classes/Controller/ExportController.php1new+615 −0
- typo3/sysext/impexp/Classes/Controller/ImportController.php3new+340 −0
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+25 −834
- typo3/sysext/impexp/Classes/Hook/BackendControllerHook.php+5 −3
- typo3/sysext/impexp/Configuration/Backend/Routes.php4+12 −1
- typo3/sysext/impexp/Resources/Private/Layouts/Default.html+0 −2
- typo3/sysext/impexp/Resources/Private/Templates/ImportExport/Export.html+2 −1
- typo3/sysext/impexp/Resources/Private/Templates/ImportExport/Import.html+2 −0
- typo3/sysext/impexp/Resources/Public/JavaScript/ContextMenuActions.js+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+2 −2
Review log 2232
Show 57 earlier messages
-
Andreas Kienast uploaded patch set 1 07/01/19, 08:15
-
Andreas Kienast uploaded patch set 2 07/01/19, 08:19
-
TYPO3com voted on patch set 1 V +1 07/01/19, 08:26 Completed build in 10m 48s on Mon, 1 Jul, 10:26 AM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34670
-
TYPO3com voted on patch set 2 V +1 07/01/19, 08:29 Completed build in 09m 58s on Mon, 1 Jul, 10:29 AM Test Summary: 46835 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34671
-
Georg Ringer commented on patch set 2 07/01/19, 11:46
isn't that breaking? -
Andreas Kienast commented on patch set 2 07/01/19, 12:00
> Patch Set 2: > > isn't that breaking? Why do you think so? Accessing the old controller will result in redirects, thus the deprecation. -
Georg Ringer commented on patch set 2 07/01/19, 17:52
and what if someone extended the importexportcontroller?
-
Andreas Kienast commented on patch set 2 07/01/19, 18:02
> Patch Set 2: > > and what if someone extended the importexportcontroller? That controller is *internal* API. -
Georg Ringer commented on patch set 2 07/01/19, 19:43
true, sorry overlooked that -
Andreas Kienast uploaded patch set 3 07/03/19, 18:23
-
TYPO3com voted on patch set 3 V +1 07/03/19, 18:34 Completed build in 10m 43s on Wed, 3 Jul, 08:34 PM Test Summary: 46840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34759
-
Daniel Windloff commented on patch set 3 07/05/19, 08:08
ExportController.php:379Unresolvedcan be removedImportController.php:142Unresolvedarray $inDataImportController.php:171Unresolvedhsc?ImportController.php:313Unresolvedstring $combinedIdentifier -
Andreas Kienast uploaded patch set 4 07/05/19, 08:24
-
TYPO3com voted on patch set 4 V +1 07/05/19, 08:37 Completed build in 13m 40s on Fri, 5 Jul, 10:37 AM Test Summary: 46700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34786
-
Andreas Kienast uploaded patch set 5 07/08/19, 07:28
-
TYPO3com voted on patch set 5 V +1 07/08/19, 07:40 Completed build in 11m 10s on Mon, 8 Jul, 09:40 AM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34839
-
Jörg Bösche voted on patch set 5 CR +1 07/09/19, 07:50
-
Tobi Kretschmann uploaded patch set 6 07/10/19, 09:11
-
TYPO3com voted on patch set 6 V +1 07/10/19, 09:20 Completed build in 09m 46s on Wed, 10 Jul, 11:20 AM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34873
-
Tobi Kretschmann uploaded patch set 7 07/10/19, 09:39
-
TYPO3com voted on patch set 7 V +1 07/10/19, 09:50 Completed build in 10m 43s on Wed, 10 Jul, 11:50 AM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34876
-
Benni Mack commented on patch set 7 07/11/19, 04:22
Routes.php:8can you add a @deprecated above this line so we know this has to be removed in TYPO3 v11.0Routes.php:12let's not keep the new cryptic naming for the entry points, let's use "tx_impexp_export" and "tx_impexp_import" please. -
Tobi Kretschmann uploaded patch set 8 07/11/19, 07:41
-
Tobi Kretschmann commented on patch set 8 07/11/19, 07:41
Routes.php:8ReplyDoneRoutes.php:12ReplyDone -
Tobi Kretschmann uploaded patch set 9 07/11/19, 07:42
-
TYPO3com voted on patch set 8 V +1 07/11/19, 08:16 Completed build in 20m 49s on Thu, 11 Jul, 10:16 AM Test Summary: 46733 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34898
-
TYPO3com voted on patch set 9 V +1 07/11/19, 08:36 Completed build in 41m 17s on Thu, 11 Jul, 10:36 AM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34899
-
Tobi Kretschmann uploaded patch set 10 07/11/19, 13:11
-
TYPO3com voted on patch set 10 V +1 07/11/19, 13:50 Completed build in 30m 57s on Thu, 11 Jul, 03:50 PM Test Summary: 46978 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34920
-
Jörg Bösche commented on patch set 10 V +1 CR +1 07/11/19, 14:08
Works for me. :-) FYI: Patchset 10 resolves the issue, that a single record (not a page) on updating (click button update) the export form throws an type cast error. -
Benni Mack voted on patch set 10 V +2 CR +2 07/13/19, 17:27
-
Benni Mack merged patch set 11 07/13/19, 17:32