Review main Abandoned Breaking

61203[WIP][!!!][TASK] Remove various side effect features of ResourceCompressor

Benni Mack CR 0 V 0 Normal +14 −55 updated 07/23/19, 09:20

Commit message

ResourceCompressor - since its inception - had a lot of side
effects due to various path "guessing" and special handling
within TYPO3 Backend.

In order to reduce complexity, but also building Resource
Compressor in a way so it is independant from a current request
the following changes have been made:
- setRootPath() is set to "internal", and rootPath is now always the
public path of TYPO3
- concatenateCssFiles() now always concatenates all local files, second method argument is dropped (was used for TBE_STYLES)
- when a CSS/JS merging happens, file references with the current local domain are still treated as external domain
- Files relative to typo3/ (e.g. "sysext/workspaces/...) do not work anymore, as this should all be handled the exact same way (e.g. EXT: or relative to public path)
- Relative files are treated as they are relative from TYPO3's Public Folder

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 916

  1. Benni Mack uploaded patch set 1 07/01/19, 09:32

  2. TYPO3com voted on patch set 1 V -1 07/01/19, 09:43 Completed build in 10m 42s on Mon, 1 Jul, 11:43 AM Test Summary: 19 of 47199 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34674

  3. Benni Mack uploaded patch set 2 07/11/19, 04:34

  4. TYPO3com voted on patch set 2 V -1 07/11/19, 04:55 Completed build in 20m 03s on Thu, 11 Jul, 06:55 AM Test Summary: 7 of 47097 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34892

  5. Benni Mack uploaded patch set 3 07/11/19, 12:24

  6. TYPO3com voted on patch set 3 V -1 07/11/19, 13:03 Completed build in 35m 53s on Thu, 11 Jul, 03:03 PM Test Summary: 3 of 47341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34914

  7. Benni Mack uploaded patch set 4 07/11/19, 19:18

  8. TYPO3com voted on patch set 4 V -1 07/11/19, 19:33 Completed build in 15m 00s on Thu, 11 Jul, 09:33 PM Test Summary: 114 of 47341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34935

  9. Benni Mack uploaded patch set 5 07/16/19, 13:20

  10. TYPO3com voted on patch set 5 V -1 07/16/19, 13:33 Completed build in 12m 49s on Tue, 16 Jul, 03:33 PM Test Summary: 51 of 47361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35093

  11. Benni Mack uploaded patch set 6 07/18/19, 07:00

  12. TYPO3com voted on patch set 6 V -1 07/18/19, 07:11 Completed build in 10m 58s on Thu, 18 Jul, 09:11 AM Test Summary: 3 of 47481 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35153

  13. Benni Mack uploaded patch set 7 07/18/19, 09:01

  14. TYPO3com voted on patch set 7 V +1 07/18/19, 09:12 Completed build in 11m 03s on Thu, 18 Jul, 11:12 AM Test Summary: 47122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35160

  15. Markus Klein commented on patch set 7 07/19/19, 09:21

    ResourceCompressor.php:247 Unresolved

    I suspect this will break cases where a local files was added to concatenation which is not publicly accessible.
  16. Benni Mack abandoned the change 07/23/19, 09:20

    won't do.