Review main Merged

61204[TASK] Move "Refresh required" modal interception into JavaScript land

Andreas Kienast CR +2 V +2 Normal +63 −73 updated 07/05/19, 13:23

Commit message

The "Refresh required" is currently built in PHP and invoked when changing
a field that is explictly configured as "onChange => reload" in TCA. Since
we aren't limited to the technology of our time anymore, the main logic
can get moved into FormEngine.js and only registration is kept in
FormEngine for now.

This commit also removed some superfluous usages of
`TBE_EDITOR_fieldChanged`, as those are already handled by FormEngine.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 810

  1. Andreas Kienast uploaded patch set 1 07/01/19, 10:30

  2. Andreas Kienast updated the commit message in patch set 2 07/01/19, 10:32

  3. TYPO3com voted on patch set 1 V +1 07/01/19, 10:44 Completed build in 13m 23s on Mon, 1 Jul, 12:44 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34677

  4. TYPO3com voted on patch set 2 V +1 07/01/19, 10:46 Completed build in 14m 17s on Mon, 1 Jul, 12:46 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34678

  5. Frank Nägler voted on patch set 2 CR +1 07/05/19, 13:10

  6. Frank Nägler voted on patch set 2 V +2 CR +2 07/05/19, 13:13

  7. Oliver Hader voted on patch set 2 CR +1 07/05/19, 13:15

  8. Anja Leichsenring commented on patch set 2 V -1 07/05/19, 13:20

    wait for me, testing in progress
  9. Anja Leichsenring commented on patch set 2 V +1 CR +1 07/05/19, 13:22

    looks good, happy merging
  10. Frank Nägler merged patch set 3 07/05/19, 13:23