Review main Merged Breaking

61207[!!!][TASK] TCA: Remove "parentPageTca" FormDataProvider

Benni Mack CR +2 V +2 Normal +42 −109 updated 07/14/19, 10:52

Commit message

The property "vanillaParentPageTca " inside FormEngine
is never used - also documented that it was never used before.

The property is therefore removed.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Björn Jacob +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 812

  1. Benni Mack uploaded patch set 1 07/01/19, 15:08

  2. TYPO3com voted on patch set 1 V +1 07/01/19, 15:18 Completed build in 10m 20s on Mon, 1 Jul, 05:18 PM Test Summary: 46832 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34693

  3. Benni Mack uploaded patch set 2 07/13/19, 13:19

  4. TYPO3com voted on patch set 2 V +1 07/13/19, 13:31 Completed build in 11m 39s on Sat, 13 Jul, 03:31 PM Test Summary: 46994 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34993

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 07/13/19, 13:42

  6. Andreas Kienast commented on patch set 3 07/13/19, 14:32

    Published edit on patch set 2.
  7. Andreas Kienast voted on patch set 3 V +1 CR +1 07/13/19, 14:33

  8. TYPO3com voted on patch set 3 V -1 07/13/19, 14:45 Completed build in 13m 11s on Sat, 13 Jul, 04:45 PM Test Summary: 46994 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34999

  9. TYPO3com voted on patch set 3 V +1 07/13/19, 14:49 Completed build in 29m 52s on Sat, 13 Jul, 04:49 PM Test Summary: 46994 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34999

  10. Björn Jacob voted on patch set 3 CR +1 07/13/19, 16:11

  11. Anja Leichsenring voted on patch set 3 V +2 CR +2 07/14/19, 10:52

  12. Anja Leichsenring merged patch set 4 07/14/19, 10:52