Review main Abandoned

61212[FEATURE] Refactor new record wizard

Daniel Windloff CR 0 V 0 Nightmare +3345 −611 updated 11/04/21, 16:29

Commit message

Adds a categorization of records beyond the technical grouping by
extension.

Add all possible records and wizards by the NewRecordProviderItemsEvent.
This allows to register additional wizards in the NewRecordController.
By default wizards for page positions (after, inside), multiple pages
and the position selection by wizard are added.
Furthermore the link to the content element wizard is added.

To provide an overview to all TCA types, the different types are shown
as sublist and could be created without further clicks.

On technical level the "Select a position for the new page" has been
moved to an other controller class.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 75

Show 55 more files

Review log 74116

Show 5891 earlier messages
  1. Daniel Windloff uploaded patch set 1 07/02/19, 12:34

  2. TYPO3com voted on patch set 1 V -1 07/02/19, 12:34 Completed build in 06s on Tue, 2 Jul, 02:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34706

  3. Daniel Windloff uploaded patch set 2 07/02/19, 12:40

  4. Daniel Windloff uploaded patch set 3 07/02/19, 12:49

  5. TYPO3com voted on patch set 3 V -1 07/02/19, 12:50 Completed build in 13s on Tue, 2 Jul, 02:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34708

  6. TYPO3com voted on patch set 2 V +1 07/02/19, 12:50 Completed build in 10m 04s on Tue, 2 Jul, 02:50 PM Test Summary: 46840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34707

  7. Daniel Windloff uploaded patch set 4 07/02/19, 12:51

  8. TYPO3com voted on patch set 4 V +1 07/02/19, 13:01 Completed build in 10m 15s on Tue, 2 Jul, 03:01 PM Test Summary: 46840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34709

  9. Daniel Windloff uploaded patch set 5 07/03/19, 11:30

  10. TYPO3com voted on patch set 5 V +1 07/03/19, 11:39 Completed build in 08m 44s on Wed, 3 Jul, 01:39 PM Test Summary: 46848 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34728

  11. Daniel Windloff uploaded patch set 6 07/03/19, 12:55

  12. TYPO3com voted on patch set 6 V -1 07/03/19, 13:08 Completed build in 13m 07s on Wed, 3 Jul, 03:08 PM Test Summary: 46846 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34735

  13. Daniel Windloff uploaded patch set 7 07/03/19, 13:56

  14. TYPO3com voted on patch set 7 V +1 07/03/19, 14:05 Completed build in 09m 23s on Wed, 3 Jul, 04:05 PM Test Summary: 46848 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34737

  15. Daniel Windloff uploaded patch set 8 07/03/19, 14:24

  16. TYPO3com voted on patch set 8 V +1 07/03/19, 14:34 Completed build in 10m 21s on Wed, 3 Jul, 04:34 PM Test Summary: 46848 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34742

  17. Daniel Windloff uploaded patch set 9 07/04/19, 09:23

  18. TYPO3com voted on patch set 9 V -1 07/04/19, 09:24 Completed build in 14s on Thu, 4 Jul, 11:23 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34768

  19. Daniel Windloff uploaded patch set 10 07/04/19, 09:34

  20. Daniel Windloff uploaded patch set 11 07/04/19, 09:44

  21. TYPO3com voted on patch set 10 V -1 07/04/19, 09:44 Completed build in 09m 58s on Thu, 4 Jul, 11:44 AM Test Summary: 46708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34769

  22. TYPO3com voted on patch set 11 V -1 07/04/19, 09:55 Completed build in 10m 34s on Thu, 4 Jul, 11:55 AM Test Summary: 46708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34770

  23. Daniel Windloff uploaded patch set 12 07/04/19, 09:57

  24. TYPO3com commented on patch set 12 07/04/19, 10:09 Completed build in 11m 26s on Thu, 4 Jul, 12:09 PM Test Summary: 46708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34774

  25. Daniel Windloff uploaded patch set 13 07/04/19, 10:16

  26. TYPO3com voted on patch set 13 V +1 07/04/19, 10:26 Completed build in 10m 01s on Thu, 4 Jul, 12:26 PM Test Summary: 46708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34775

  27. Daniel Windloff uploaded patch set 14 07/04/19, 10:43

  28. TYPO3com voted on patch set 14 V +1 07/04/19, 10:53 Completed build in 09m 59s on Thu, 4 Jul, 12:53 PM Test Summary: 46708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34776

  29. Andreas Kienast commented on patch set 14 CR -1 07/05/19, 09:01

    On it
  30. Andreas Kienast uploaded patch set 15 07/05/19, 09:40

  31. Andreas Kienast commented on patch set 15 07/05/19, 09:41

    ProviderInterface.php:36 Unresolved

    I kinda dislike the returnUrl argument here, as it's used in ContentWizardProvider only.
  32. TYPO3com voted on patch set 15 V +1 07/05/19, 09:50 Completed build in 10m 02s on Fri, 5 Jul, 11:50 AM Test Summary: 46708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34792

  33. Andreas Kienast uploaded patch set 16 07/05/19, 09:58

  34. TYPO3com voted on patch set 16 V +1 07/05/19, 10:09 Completed build in 11m 01s on Fri, 5 Jul, 12:09 PM Test Summary: 46708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34793

  35. Andreas Kienast voted on patch set 16 V +1 CR +1 07/05/19, 14:44

  36. Oliver Klee commented on patch set 16 07/05/19, 14:47

    Wow, this is one huge refactoring … :-O Would it be possible to split it up so each changeset it about a single (or only few) refactoring(s) at a time? That would make reviews a lot easier and faster.
  37. Daniel Windloff commented on patch set 16 07/05/19, 17:12

    > Patch Set 16: > > Wow, this is one huge refactoring … :-O > > Would it be possible to split it up so each changeset it about a single (or only few) refactoring(s) at a time? That would make reviews a lot easier and faster. I think it would be more work to write or review serveral patches. The code I refactor was mixed up, so it is hard to not refactor the whole code.
  38. Oliver Klee commented on patch set 16 07/05/19, 17:42

    > I think it would be more work to write or review serveral patches. I agree on the "writing" part and disagree on the "reviewing" part. :-)
  39. Steffen Frese commented on patch set 16 CR -1 07/09/19, 08:40

    AbstractRecord.php:18

    IMHO this should be an interface and it should have a method which allows you to remove those dirty `instanceof` conditions in RecordSortingViewHelper::sortRecordsByTitle . This also makes RecordSortingViewHelper::sortRecordsByTitle way more maintainable because all if conditions could be removed.
  40. Daniel Windloff uploaded patch set 17 07/09/19, 14:55

  41. Daniel Windloff commented on patch set 17 07/09/19, 15:03

    AbstractRecord.php:18 Reply Unresolved

    Replaced abstract class by interface and removed instanceof in the record sorting ViewHelper. I let 2 ifs there, to add a space if the additional title is not empty.
  42. TYPO3com voted on patch set 17 V +1 07/09/19, 15:08 Completed build in 12m 43s on Tue, 9 Jul, 05:08 PM Test Summary: 46742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34866

  43. Steffen Frese uploaded patch set 18 07/10/19, 09:32

  44. TYPO3com voted on patch set 18 V +1 07/10/19, 09:44 Completed build in 12m 24s on Wed, 10 Jul, 11:44 AM Test Summary: 46742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34875

  45. Daniel Windloff uploaded patch set 19 07/11/19, 08:15

  46. Daniel Windloff commented on patch set 19 07/11/19, 08:23

    Just resolved a merge conflict.
  47. TYPO3com voted on patch set 19 V +1 07/11/19, 08:54 Completed build in 26m 15s on Thu, 11 Jul, 10:54 AM Test Summary: 46742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34902

  48. Markus Klein updated the commit message in patch set 20 07/12/19, 09:45

  49. TYPO3com voted on patch set 20 V +1 07/12/19, 10:01 Completed build in 16m 23s on Fri, 12 Jul, 12:01 PM Test Summary: 46986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34951

  50. Jörg Bösche uploaded patch set 21 07/12/19, 12:28

  51. TYPO3com voted on patch set 21 V +1 07/12/19, 12:51 Completed build in 18m 23s on Fri, 12 Jul, 02:51 PM Test Summary: 47006 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34963

  52. Daniel Windloff uploaded patch set 22 07/16/19, 14:49

  53. Daniel Windloff commented on patch set 22 07/16/19, 14:53

    Just resolved a merge conflict.
  54. TYPO3com voted on patch set 22 V +1 07/16/19, 15:00 Completed build in 10m 18s on Tue, 16 Jul, 05:00 PM Test Summary: 47126 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35102

  55. Daniel Windloff uploaded patch set 23 07/17/19, 08:53

  56. Daniel Windloff commented on patch set 23 07/17/19, 09:03

    Just resolved a merge conflict
  57. TYPO3com voted on patch set 23 V +1 07/17/19, 09:03 Completed build in 09m 44s on Wed, 17 Jul, 11:03 AM Test Summary: 47126 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35122

  58. Daniel Windloff uploaded patch set 24 07/17/19, 09:13

  59. TYPO3com voted on patch set 24 V +1 07/17/19, 09:25 Completed build in 11m 12s on Wed, 17 Jul, 11:24 AM Test Summary: 47126 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35123

  60. Daniel Windloff commented on patch set 24 07/17/19, 09:26

    Replaced code, that is deprecated now
  61. Markus Klein commented on patch set 24 07/19/19, 09:07

    Only a few comments. Wow this change is massive.

    AccessUtility.php:24

    public

    DefaultNewRecord.php:94

    no need for such a doc-block, no additional value

    DefaultNewRecord.php:173

    same with these all

    Feature-88678-IntroduceAdditionalRecordGroupsInTheNewRecordWizard.rst:13

    TCA

    Feature-88678-IntroduceAdditionalRecordGroupsInTheNewRecordWizard.rst:26

    registered

    Feature-88678-IntroduceAdditionalRecordGroupsInTheNewRecordWizard.rst:33

    iconIdentifier
  62. Daniel Windloff uploaded patch set 25 07/19/19, 09:21

  63. Daniel Windloff commented on patch set 25 07/19/19, 09:22

    AccessUtility.php:24 Reply

    Done

    DefaultNewRecord.php:94 Reply

    Done

    DefaultNewRecord.php:173 Reply

    Done

    Feature-88678-IntroduceAdditionalRecordGroupsInTheNewRecordWizard.rst:13 Reply

    Done

    Feature-88678-IntroduceAdditionalRecordGroupsInTheNewRecordWizard.rst:26 Reply

    Done

    Feature-88678-IntroduceAdditionalRecordGroupsInTheNewRecordWizard.rst:33 Reply

    Done
  64. TYPO3com voted on patch set 25 V +1 07/19/19, 09:36 Completed build in 15m 46s on Fri, 19 Jul, 11:36 AM Test Summary: 47198 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35195

  65. Andreas Kienast uploaded patch set 26 07/19/19, 09:38

  66. Andreas Kienast voted on patch set 26 V +1 CR +1 07/19/19, 09:39

  67. Markus Klein commented on patch set 26 07/19/19, 09:46

    PagesAfterProvider.php:143

    don't we have constants for these?
  68. TYPO3com voted on patch set 26 V +1 07/19/19, 09:49 Completed build in 11m 02s on Fri, 19 Jul, 11:49 AM Test Summary: 47198 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35197

  69. Daniel Windloff uploaded patch set 27 07/19/19, 09:56

  70. Daniel Windloff commented on patch set 27 07/19/19, 09:58

    PagesAfterProvider.php:143 Reply

    Done
  71. TYPO3com voted on patch set 27 V +1 07/19/19, 10:06 Completed build in 10m 02s on Fri, 19 Jul, 12:06 PM Test Summary: 47198 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35198

  72. Daniel Windloff uploaded patch set 28 07/29/19, 10:52

  73. Daniel Windloff commented on patch set 28 07/29/19, 11:08

    Resolved merge confict.
  74. TYPO3com voted on patch set 28 V +1 07/29/19, 11:09 Completed build in 16m 24s on Mon, 29 Jul, 01:09 PM Test Summary: 47168 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35361

  75. Andreas Kienast voted on patch set 28 V +1 CR +1 07/29/19, 11:16

  76. Oliver Hader commented on patch set 28 CR -1 07/29/19, 14:40

    Thanks for your patch. However, I did not succeed in identifying which problem exactly shall be solved. The `groupName` assignment probably is wrong in TCA - should basically should be used for schema-related topics. Besides that, I think the new "models" implementing new interfaces are "a bit too much"...
  77. Daniel Windloff commented on patch set 28 07/29/19, 16:12

    > Patch Set 28: Code-Review-1 > > Thanks for your patch. However, I did not succeed in identifying which problem exactly shall be solved. I wanted to tackle two problems: 1) I have are extensions that look like styleguide. You have a huge number of possible TCA records that is grouped only by the extension. For an editor it es hard to find the fitting record. So the purpose of this patch is to add the possibility to create groups of TCA records, that could reflect a topic of the TCA records. Furthermore, it is possible to create more than one record group in one extension. 2) If a TCA record has different types, it is unnecessary hard to get a new one. So I added the possibility to create a non default type with one click. In contrast, the current implementation has the following steps: Click to the record; select a type; confirm; reload; done. Furthermore, a user could see the possible record types much earlier and know at this point that a backend user could be an admin for example. > The `groupName` assignment probably is wrong in TCA - should basically should be used for schema-related topics. The groupName is not new: https://docs.typo3.org/m/typo3/reference-tca/master/en-us/Ctrl/Index.html#groupname . It is used to group a record to one other extension in the NeRecordWizard. > Besides that, I think the new "models" implementing new interfaces are "a bit too much"... For me the current implementation of the wizard is a mess. I'd try to split it in smaller chunks. That allows to extend the functionality (for example linking to the multiple pages wizard). What do you suggest?
  78. Benni Mack abandoned the change 03/23/20, 14:55

    no movement, abandoning now
  79. Daniel Windloff restored the change 08/09/20, 08:07

  80. Daniel Windloff uploaded patch set 29 08/09/20, 08:08

  81. TYPO3com voted on patch set 29 V -1 08/09/20, 08:08 Completed build in 27s on Sun, 9 Aug, 08:08 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4510

  82. Daniel Windloff uploaded patch set 30 08/09/20, 08:12

  83. Daniel Windloff uploaded patch set 31 08/09/20, 08:14

  84. Daniel Windloff uploaded patch set 32 08/09/20, 08:16

  85. Daniel Windloff uploaded patch set 33 08/09/20, 08:24

  86. TYPO3com voted on patch set 30 V -1 08/09/20, 08:24 Completed build in 11m 36s on Sun, 9 Aug, 08:24 AM Test Summary: 695 of 73467 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4511

  87. TYPO3com voted on patch set 31 V -1 08/09/20, 08:27 Completed build in 13m 22s on Sun, 9 Aug, 08:27 AM Test Summary: 695 of 73467 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4512

  88. Daniel Windloff uploaded patch set 34 08/09/20, 08:27

  89. TYPO3com voted on patch set 32 V -1 08/09/20, 08:31 Completed build in 13m 01s on Sun, 9 Aug, 08:31 AM Test Summary: 12 of 73467 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4513

  90. Daniel Windloff uploaded patch set 35 08/09/20, 08:33

  91. TYPO3com voted on patch set 33 V -1 08/09/20, 08:36 Completed build in 11m 45s on Sun, 9 Aug, 08:36 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4514

  1. TYPO3com voted on patch set 34 V -1 08/09/20, 08:40 Completed build in 12m 05s on Sun, 9 Aug, 08:40 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4515

  2. TYPO3com voted on patch set 35 V +1 08/09/20, 08:46 Completed build in 12m 45s on Sun, 9 Aug, 08:46 AM Test Summary: 72982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4516

  3. Daniel Windloff uploaded patch set 36 08/09/20, 08:56

  4. TYPO3com voted on patch set 36 V -1 08/09/20, 08:56 Completed build in 29s on Sun, 9 Aug, 08:56 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4517

  5. Oliver Hader wrote 08/09/20, 09:06

    Removed reviewer Oliver Hader.
  6. Oliver Klee wrote 08/09/20, 10:55

    Removed reviewer Oliver Klee.
  7. Daniel Windloff uploaded patch set 37 08/09/20, 17:29

  8. TYPO3com voted on patch set 37 V +1 08/09/20, 17:40 Completed build in 11m 14s on Sun, 9 Aug, 05:40 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4527

  9. Daniel Windloff uploaded patch set 38 08/14/20, 08:36

  10. TYPO3com voted on patch set 38 V +1 08/14/20, 08:49 Completed build in 12m 21s on Fri, 14 Aug, 08:49 AM Test Summary: 72997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4653

  11. Daniel Windloff uploaded patch set 39 08/14/20, 10:02

  12. TYPO3com voted on patch set 39 V -1 08/14/20, 10:13 Completed build in 11m 22s on Fri, 14 Aug, 10:13 AM Test Summary: 1 of 73482 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4654

  13. Daniel Windloff uploaded patch set 40 08/14/20, 11:13

  14. TYPO3com voted on patch set 40 V +1 08/14/20, 11:25 Completed build in 11m 25s on Fri, 14 Aug, 11:25 AM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4656

  15. Daniel Windloff uploaded patch set 41 08/15/20, 16:00

  16. Daniel Windloff commented on patch set 41 08/15/20, 16:05

    Resolve merge conflict (7).
  17. TYPO3com voted on patch set 41 V +1 08/15/20, 16:11 Completed build in 10m 45s on Sat, 15 Aug, 04:11 PM Test Summary: 72995 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4700

  18. Helmut Hummel commented on patch set 41 08/16/20, 17:53

    NewRecordGroupsEvent.php:73

    Please use API to calculate absolute paths (GeneralUtility::getFileAbsFileName)
  19. Helmut Hummel commented on patch set 41 08/17/20, 07:50

    NewRecordGroupsEvent.php:68

    maybe throw an exception here?

    ExtensionRecordGroups.php:92

    the API should be designed that the iconFile is an absolute path in the form: 'EXT:ext_key/Resources/Public', or maybe even better, only allow icon identifiers and register the extension icons in the icon registry

    TcaRecordGroups.php:49

    the string cast takes precedence over the tenary operater, thus this will emmit a noticw when the key is not set
  20. Daniel Windloff uploaded patch set 42 08/17/20, 15:09

  21. TYPO3com voted on patch set 42 V +1 08/17/20, 15:21 Completed build in 11m 47s on Mon, 17 Aug, 03:21 PM Test Summary: 73010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4735

  22. Daniel Windloff commented on patch set 42 08/17/20, 15:22

    NewRecordGroupsEvent.php:68 Reply

    Done

    NewRecordGroupsEvent.php:73 Reply

    Done

    ExtensionRecordGroups.php:92 Reply Unresolved

    Yes, the new suggested API recommends icon identifiers. This provider just tries to restore the current behavior. The extension icons aren't handled by the IconFactory. To add this registration also affects other places like the extensionmanager. That's why I don't take it into account here as I wouldn't like to mix up these changes.

    TcaRecordGroups.php:49 Reply

    Done
  23. Benni Mack commented on patch set 42 10/21/21, 14:55

    care to rebase this one? As this patch is rather huge, we've already split the change into smaller chunks / pre-patches: * Separate entrypoint instead of ?pagesOnly * Added the group information to all Core TCA information
  24. Christian Kuhn commented on patch set 42 11/04/21, 16:29

    Hey. I'll abandon this patch for now: It didn't receive much love for a while, has a couple of bigger conflicts and it might be better to split the patch into smaller chunks to bring it in. It will continue to hang in the review system and can be viewed / referred to or resurrected when work continues here.
  25. Christian Kuhn abandoned the change 11/04/21, 16:29