Review main Merged

61214[TASK] Streamline PageRenderer class

Benni Mack CR +2 V +2 Easy +11 −19 updated 07/03/19, 14:43

Commit message

Some methods are not in use anymore, and also
some FQCN can be shortened in order to
clean up this class for further refactorings.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Sven Juergens +1
    • Oliver Klee +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Benni Mack uploaded patch set 1 07/02/19, 16:37

  2. TYPO3com voted on patch set 1 V +1 07/02/19, 16:49 Completed build in 11m 30s on Tue, 2 Jul, 06:49 PM Test Summary: 46840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34716

  3. Sven Juergens voted on patch set 1 CR +1 07/02/19, 17:26

  4. Alexander Schnitzler commented on patch set 1 CR +1 07/03/19, 10:11

    PageRenderer.php:2531

    Isn't this kind of breaking when PageRenderer has been extended by a userland class?
  5. Benni Mack commented on patch set 1 07/03/19, 11:24

    PageRenderer.php:2531 Reply Unresolved

    XCLASSing isn't covered by our BC promise.
  6. Alexander Schnitzler voted on patch set 1 V +1 07/03/19, 11:37

  7. Oliver Klee voted on patch set 1 CR +1 07/03/19, 12:34

  8. Andreas Kienast voted on patch set 1 V +2 CR +2 07/03/19, 14:43

  9. Andreas Kienast merged patch set 2 07/03/19, 14:43