Review main Merged

61215[TASK] Optimize and cleanup replaceAndAppendScalarValuesRecursive()

Simon Gilli CR +2 V +2 Normal +75 −20 updated 08/23/19, 10:53

Commit message

This optimizes ArrayUtility::replaceAndAppendScalarValuesRecursive() by
moving parts into new method hasStringKeys and removing other
duplicated code.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2334

Show 59 earlier messages
  1. Simon Gilli uploaded patch set 1 07/02/19, 22:15

  2. TYPO3com voted on patch set 1 V -1 07/02/19, 22:16 Completed build in 16s on Wed, 3 Jul, 12:16 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34725

  3. Simon Gilli marked it work in progress 07/02/19, 22:22

  4. Simon Gilli uploaded patch set 2 07/03/19, 12:01

  5. TYPO3com voted on patch set 2 V -1 07/03/19, 12:01 Completed build in 06s on Wed, 3 Jul, 02:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34730

  6. Simon Gilli uploaded patch set 3 07/03/19, 12:21

  7. TYPO3com voted on patch set 3 V -1 07/03/19, 12:21 Completed build in 06s on Wed, 3 Jul, 02:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34732

  8. Simon Gilli uploaded patch set 4 07/03/19, 14:11

  9. TYPO3com voted on patch set 4 V -1 07/03/19, 14:11 Completed build in 06s on Wed, 3 Jul, 04:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34739

  1. Simon Gilli rebased onto patch set 5 07/03/19, 15:11

  2. TYPO3com voted on patch set 5 V -1 07/03/19, 15:11 Completed build in 08s on Wed, 3 Jul, 05:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34749

  3. Simon Gilli commented on patch set 5 07/03/19, 15:18

    This change is ready for review.
  4. Simon Gilli rebased onto patch set 6 07/04/19, 09:55

  5. TYPO3com voted on patch set 6 V -1 07/04/19, 09:55 Completed build in 06s on Thu, 4 Jul, 11:55 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34771

  6. Simon Gilli uploaded patch set 7 07/05/19, 12:48

  7. TYPO3com voted on patch set 7 V -1 07/05/19, 12:49 Completed build in 06s on Fri, 5 Jul, 02:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34807

  8. Simon Gilli rebased onto patch set 8 07/12/19, 13:25

  9. Simon Gilli updated the commit message in patch set 9 07/12/19, 13:28

  10. TYPO3com voted on patch set 8 V +1 07/12/19, 13:40 Completed build in 15m 04s on Fri, 12 Jul, 03:40 PM Test Summary: 47010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34969

  11. TYPO3com voted on patch set 9 V +1 07/12/19, 13:57 Completed build in 23m 30s on Fri, 12 Jul, 03:57 PM Test Summary: 47010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34971

  12. Mathias Brodala commented on patch set 9 07/18/19, 07:00

    ArrayUtility.php:872

    As the description already indicates this could be named "isAssociative".
  13. Oliver Klee commented on patch set 9 07/18/19, 07:25

    Is this an optimization (i.e., it's faster now) or a cleanup/refactoring?

    ArrayUtility.php:872

    : bool
  14. Simon Gilli uploaded patch set 10 07/18/19, 12:56

  15. Simon Gilli commented on patch set 10 07/18/19, 12:58

    Reply

    A bit of both. Changes were suggested by Alex in an other patch. So how to proceed here? I changed the commit message a little bit.

    ArrayUtility.php:872 Reply

    Ack

    ArrayUtility.php:872 Reply

    Ack
  16. Simon Gilli commented on patch set 10 07/18/19, 12:59

    ArrayUtility.php:872 Reply

    Done

    ArrayUtility.php:872 Reply

    Done
  17. Oliver Klee voted on patch set 10 CR +1 07/18/19, 13:03

  18. TYPO3com voted on patch set 10 V -1 07/18/19, 13:10 Completed build in 13m 19s on Thu, 18 Jul, 03:10 PM Test Summary: 12 of 47561 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35168

  19. Simon Gilli uploaded patch set 11 07/18/19, 13:27

  20. Oliver Klee voted on patch set 11 CR +1 07/18/19, 13:38

  21. TYPO3com voted on patch set 11 V +1 07/18/19, 13:42 Completed build in 12m 39s on Thu, 18 Jul, 03:42 PM Test Summary: 47202 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35172

  22. Simon Gilli commented on patch set 11 07/19/19, 09:59

    Reply

    Done
  23. Anja Leichsenring voted on patch set 11 V +1 CR +1 08/02/19, 18:23

  24. Frank Nägler voted on patch set 11 V +2 CR +2 08/23/19, 10:53

  25. Frank Nägler merged patch set 12 08/23/19, 10:53