61215[TASK] Optimize and cleanup replaceAndAppendScalarValuesRecursive()
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Oliver Klee +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Frank Nägler +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2334
Show 59 earlier messages
-
Simon Gilli uploaded patch set 1 07/02/19, 22:15
-
TYPO3com voted on patch set 1 V -1 07/02/19, 22:16 Completed build in 16s on Wed, 3 Jul, 12:16 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34725
-
Simon Gilli marked it work in progress 07/02/19, 22:22
-
Simon Gilli uploaded patch set 2 07/03/19, 12:01
-
TYPO3com voted on patch set 2 V -1 07/03/19, 12:01 Completed build in 06s on Wed, 3 Jul, 02:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34730
-
Simon Gilli uploaded patch set 3 07/03/19, 12:21
-
TYPO3com voted on patch set 3 V -1 07/03/19, 12:21 Completed build in 06s on Wed, 3 Jul, 02:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34732
-
Simon Gilli uploaded patch set 4 07/03/19, 14:11
-
TYPO3com voted on patch set 4 V -1 07/03/19, 14:11 Completed build in 06s on Wed, 3 Jul, 04:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34739
-
Simon Gilli rebased onto patch set 5 07/03/19, 15:11
-
TYPO3com voted on patch set 5 V -1 07/03/19, 15:11 Completed build in 08s on Wed, 3 Jul, 05:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34749
-
Simon Gilli commented on patch set 5 07/03/19, 15:18
This change is ready for review. -
Simon Gilli rebased onto patch set 6 07/04/19, 09:55
-
TYPO3com voted on patch set 6 V -1 07/04/19, 09:55 Completed build in 06s on Thu, 4 Jul, 11:55 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34771
-
Simon Gilli uploaded patch set 7 07/05/19, 12:48
-
TYPO3com voted on patch set 7 V -1 07/05/19, 12:49 Completed build in 06s on Fri, 5 Jul, 02:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34807
-
Simon Gilli rebased onto patch set 8 07/12/19, 13:25
-
Simon Gilli updated the commit message in patch set 9 07/12/19, 13:28
-
TYPO3com voted on patch set 8 V +1 07/12/19, 13:40 Completed build in 15m 04s on Fri, 12 Jul, 03:40 PM Test Summary: 47010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34969
-
TYPO3com voted on patch set 9 V +1 07/12/19, 13:57 Completed build in 23m 30s on Fri, 12 Jul, 03:57 PM Test Summary: 47010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34971
-
Mathias Brodala commented on patch set 9 07/18/19, 07:00
ArrayUtility.php:872As the description already indicates this could be named "isAssociative". -
Oliver Klee commented on patch set 9 07/18/19, 07:25
Is this an optimization (i.e., it's faster now) or a cleanup/refactoring?ArrayUtility.php:872: bool -
Simon Gilli uploaded patch set 10 07/18/19, 12:56
-
Simon Gilli commented on patch set 10 07/18/19, 12:58
Reply
A bit of both. Changes were suggested by Alex in an other patch. So how to proceed here? I changed the commit message a little bit.ArrayUtility.php:872ReplyAckArrayUtility.php:872ReplyAck -
Simon Gilli commented on patch set 10 07/18/19, 12:59
ArrayUtility.php:872ReplyDoneArrayUtility.php:872ReplyDone -
Oliver Klee voted on patch set 10 CR +1 07/18/19, 13:03
-
TYPO3com voted on patch set 10 V -1 07/18/19, 13:10 Completed build in 13m 19s on Thu, 18 Jul, 03:10 PM Test Summary: 12 of 47561 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35168
-
Simon Gilli uploaded patch set 11 07/18/19, 13:27
-
Oliver Klee voted on patch set 11 CR +1 07/18/19, 13:38
-
TYPO3com voted on patch set 11 V +1 07/18/19, 13:42 Completed build in 12m 39s on Thu, 18 Jul, 03:42 PM Test Summary: 47202 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35172
-
Simon Gilli commented on patch set 11 07/19/19, 09:59
Reply
Done -
Anja Leichsenring voted on patch set 11 V +1 CR +1 08/02/19, 18:23
-
Frank Nägler voted on patch set 11 V +2 CR +2 08/23/19, 10:53
-
Frank Nägler merged patch set 12 08/23/19, 10:53