Review main Abandoned

61217[TASK] Deprecate YamlFileLoader->merge()

Simon Gilli CR 0 V 0 Easy +35 −1 updated 07/03/19, 15:04

Commit message

Method was moved to ArrayUtility and therefor will be deprecated here.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 811

  1. Simon Gilli uploaded patch set 1 07/03/19, 13:33

  2. TYPO3com voted on patch set 1 V -1 07/03/19, 13:33 Completed build in 06s on Wed, 3 Jul, 03:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34736

  3. Simon Gilli marked it work in progress 07/03/19, 13:34

  4. Alexander Schnitzler commented on patch set 1 CR -1 07/03/19, 13:37

    YamlFileLoader.php:208

    __METHOD__ already contains the class name.
  5. Simon Gilli rebased onto patch set 2 07/03/19, 14:13

  6. TYPO3com voted on patch set 2 V -1 07/03/19, 14:13 Completed build in 10s on Wed, 3 Jul, 04:13 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34741

  7. Simon Gilli commented on patch set 2 07/03/19, 14:18

    YamlFileLoader.php:208 Reply

    I copied this from GeneralUtility::idnaEncode, will patch this one too...
  8. Simon Gilli uploaded patch set 3 07/03/19, 14:28

  9. TYPO3com voted on patch set 3 V -1 07/03/19, 14:28 Completed build in 07s on Wed, 3 Jul, 04:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34743

  10. Benni Mack commented on patch set 3 07/03/19, 14:45

    please abandon and delete this method with the main patch. the method is protected, and XCLASSing is not covered by our BC promise. I will start writing a document about our deprecation policy which we started with 9.5
  11. Simon Gilli abandoned the change 07/03/19, 15:04

    XCLASSing is not covered by our BC promise